Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change kAirtonMaxTemp from 25C to 31C #2124

Merged
merged 1 commit into from
Aug 28, 2024
Merged

change kAirtonMaxTemp from 25C to 31C #2124

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/ir_Airton.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ const uint8_t kAirtonFanHigh = 0b100; // 4
const uint8_t kAirtonFanMax = 0b101; // 5

const uint8_t kAirtonMinTemp = 16; // 16C
const uint8_t kAirtonMaxTemp = 25; // 25C
const uint8_t kAirtonMaxTemp = 31; // 31C
Copy link
Owner

@crankyoldgit crankyoldgit Aug 1, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @BorisKofman
The original collected data (See https://docs.google.com/spreadsheets/d/1l-qo6LPPkBYUGSJ65j3-j3iQJg7lGAo96AzR4s6NDOA/edit?gid=1846254508#gid=1846254508&range=D5:D15) provided by @jonesy2 only went to 25C. Have you got any captures of from a remote that confirms it goes as high as 31C? I was surprised at the time that it only went to 25C but that's all the data showed. If I was to bet money, I too would expect it to go to 31C. But before I change it for everyone, can you please provide a capture of some values between 25C and 31C?

Otherwise, this looks fine to me.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @crankyoldgit,
I am working on project that control Air conditioner by remote type from HomeKit with Homespan.
Some one contacted me about one of AC that not passing 25C after checking and replacing this it passed and get till 31. I will try to get you samples but it will take me few days as I need contact this person.
Thanks!

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Please do. I'm happy to wait.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @crankyoldgit Here is fully HEX from IR Transmitter:

16
F28400003911D3
17
F18400013911D3
18
F08400023911D3
19
F78400033911D3
20
F68400043911D3
21
F58400053911D3
22
F48400063911D3
23
FB8400073911D3
24
FA8400083911D3
25
F98400093911D3
26
F884000A3911D3
27
FF84000B3911D3
28
FE84000C3911D3
29
FD84000D3911D3
30
FC84000E3911D3
31
E384000F3911D3

Tried to make dump with this code:

airtonAc.setRaw(results.value);
uint8_t tempByte = (results.value >> 16) & 0xFF; 
Serial.print("Temperature byte in hex: ");
Serial.println(tempByte, HEX);

but without success

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@crankyoldgit do you need additional info ?
Thanks!

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nope. Looks good to me.



/// Class for handling detailed Airton 56-bit A/C messages.
Expand Down
Loading