Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[basic.pre] Defragment specification of names and entities #7122

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

AlisdairM
Copy link
Contributor

The current contents of [basic.pre] jump between specifying different things. This PR moves all the specification of names to the front, followed by the specification of entities.

There are two main benefits: (1) the specification for when two names are the same is a list of 4 rules that correspond to the 4 things than can form a name --- the connection is much clearer when the paragraphs are adjacent and the list is sorted to the same order; (2) in this form, even though all the words are the same, the reordering and merging of paragraphs a fit on a single page. The very last paragraph was forced over a page-break in the original layout.

@wg21bot wg21bot added the needs rebase The pull request needs a git rebase to resolve merge conflicts. label Dec 23, 2024
The current contents of [basic.pre] jump between specifying
different things.  This PR moves all the specification of
names to the front, followed by the specification of entities.

There are two main benefits: (1) the specification for when
two names are the same is a list of 4 rules that correspond
to the 4 things than can form a name --- the connection is
much clearer when the paragraphs are adjacent and the list
is sorted to the same order; (2) in this form, even though
all the words are the same, the reordering and merging of
paragraphs a fit on a single page.  The very last paragraph
was forced over a page-break in the original layout.
@AlisdairM AlisdairM force-pushed the defrag_names_and_entities branch from ae92518 to 4c29852 Compare January 21, 2025 09:33
@AlisdairM
Copy link
Contributor Author

Re-applied edits on the latest working draft, to ensure that any wording updates in this subclause are preserved. Requested rebasing complete.

@jensmaurer jensmaurer removed the needs rebase The pull request needs a git rebase to resolve merge conflicts. label Jan 21, 2025
Copy link
Member

@jensmaurer jensmaurer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The rationale "fits on one page" is of course bogus, because CWG will update this as it sees fit.

I think this is an improvement; I can't see the potential for harm given that text is moved around locally a bit.

@tkoeppe?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants