Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused .travis.yml file #426

Merged
merged 1 commit into from
Jan 29, 2024
Merged

Conversation

jwakely
Copy link
Member

@jwakely jwakely commented Jan 29, 2024

GitHub Actions replaced the Travis CI two years ago. Add the checks for carriage returns and valid XML to the new CI config.

GitHub Actions replaced the Travis CI two years ago. Add the checks for
carriage returns and valid XML to the new CI config.
@jwakely
Copy link
Member Author

jwakely commented Jan 29, 2024

Do we want to restore these CI checks which stopped running when Travis CI was decommissioned?

@Dani-Hub
Copy link
Member

Do we want to restore these CI checks which stopped running when Travis CI was decommissioned?

I have no strong opinion. What is your preference?

@jwakely
Copy link
Member Author

jwakely commented Jan 29, 2024

There were quite a lot of XML validation errors that I fixed in 97cae0d. If we re-enabled validation in the CI that would be avoided.

@Dani-Hub
Copy link
Member

There were quite a lot of XML validation errors that I fixed in 97cae0d. If we re-enabled validation in the CI that would be avoided.

Great, so lets do it!

@jwakely jwakely merged commit ce49cad into cplusplus:master Jan 29, 2024
2 checks passed
@jwakely
Copy link
Member Author

jwakely commented Jan 29, 2024

OK, done - this means we can't use the backticks feature for inline code now though.

@jwakely jwakely deleted the rm-travis branch January 29, 2024 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants