Mathcomp 2.x #29
Open
Mathcomp 2.x #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ablearthy
force-pushed
the
mathcomp-230
branch
from
8546ec5 to
e277222
Compare
ablearthy
force-pushed
the
mathcomp-230
branch
from
e277222 to
d272f37
Compare
ablearthy
commented
Jan 5, 2025
| @@ -741,7 +742,7 @@ Admitted. | |||
| End Exercises. | |||
|
|
|||
| Section Optimization. | |||
| Context {disp : unit} {T : orderType disp}. | |||
There was a problem hiding this comment.
In mathcomp 2.2 disp : unit works, but not in 2.3.
Conversely, disp : Order.disp_t works in 2.3, not not in 2.2.
So I dropped support for 2.2
ablearthy
commented
Jan 5, 2025
Comment on lines
-770
to
-775
| Canonical ivl_latticeType := | ||
| Eval hnf in LatticeType ivl ivl_totalPOrderMixin. | ||
| Canonical ivl_distrLatticeType := | ||
| Eval hnf in DistrLatticeType ivl ivl_totalPOrderMixin. | ||
| Canonical ivl_orderType := | ||
| Eval hnf in OrderType ivl ivl_totalPOrderMixin. |
There was a problem hiding this comment.
I have no idea how to instantiate these, but it works without them. Maybe instances are used for exercises?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #22.