Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why not minify it #6

Closed
wants to merge 1 commit into from
Closed

Conversation

Electogenius
Copy link

(this wasn't tested so judging by my skills it probably doesn't work)

(this wasn't tested so judging by my skills it probably doesn't work)
@coolaj86
Copy link
Owner

coolaj86 commented Dec 2, 2021

Primarily because a TCP packet is 1500 bytes, meaning that sending less data typically isn’t any faster.

But why not? Let’s do it!

#Over9000 #ToTheMoon!

@coolaj86
Copy link
Owner

coolaj86 commented Dec 2, 2021

However, I’d recommend instead adding the minification process to the package.json pre-publish So that it automatically builds and gets included in the npm publish.

(and so we don’t junk up the source code with build files 😉)

npx uglify-js -o ajquery.min.js ajquery.js

Something like that, I think ^^.

@Electogenius
Copy link
Author

Oh, cool

In that case you could just uh, not change anything and close this PR

But thanks for letting me know about the pre-publish thingy, I’ll remember to use it if I can

Also thanks for giving me an excuse to not minify js I make hehe

@coolaj86
Copy link
Owner

coolaj86 commented Jun 7, 2022

Hmm... looks like pre-publish doesn't do you any good when services like unpkg go down unexpectedly and stuff starts breaking... 😢

@coolaj86
Copy link
Owner

Update on this: We minify much harder now, see #12.

Also, there's been a big update and the new, bigger, badder files are available pre-optimized for bundling:

@coolaj86 coolaj86 closed this Aug 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants