Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include HTTP error codes in the findOne method #250

Merged
merged 2 commits into from
Dec 2, 2024
Merged

Include HTTP error codes in the findOne method #250

merged 2 commits into from
Dec 2, 2024

Conversation

sunil-lakshman
Copy link
Contributor

No description provided.

@sunil-lakshman sunil-lakshman changed the base branch from master to development November 28, 2024 08:17
@github-actions GitHub Actions
Copy link

We regret to inform you that you are currently not able to merge your changes into the master branch due to restrictions applied by our SRE team. To proceed with merging your changes, we kindly request that you create a pull request from the staging branch. Our team will then review the changes and work with you to ensure a successful merge into the master branch.

4 similar comments
@github-actions GitHub Actions
Copy link

We regret to inform you that you are currently not able to merge your changes into the master branch due to restrictions applied by our SRE team. To proceed with merging your changes, we kindly request that you create a pull request from the staging branch. Our team will then review the changes and work with you to ensure a successful merge into the master branch.

@github-actions GitHub Actions
Copy link

We regret to inform you that you are currently not able to merge your changes into the master branch due to restrictions applied by our SRE team. To proceed with merging your changes, we kindly request that you create a pull request from the staging branch. Our team will then review the changes and work with you to ensure a successful merge into the master branch.

@github-actions GitHub Actions
Copy link

We regret to inform you that you are currently not able to merge your changes into the master branch due to restrictions applied by our SRE team. To proceed with merging your changes, we kindly request that you create a pull request from the staging branch. Our team will then review the changes and work with you to ensure a successful merge into the master branch.

@github-actions GitHub Actions
Copy link

We regret to inform you that you are currently not able to merge your changes into the master branch due to restrictions applied by our SRE team. To proceed with merging your changes, we kindly request that you create a pull request from the staging branch. Our team will then review the changes and work with you to ensure a successful merge into the master branch.

@sunil-lakshman sunil-lakshman marked this pull request as ready for review November 29, 2024 10:54
@sunil-lakshman sunil-lakshman requested a review from a team as a code owner November 29, 2024 10:54
nadeem-cs
nadeem-cs reviewed Nov 29, 2024
View reviewed changes
Copy link
Contributor

@nadeem-cs nadeem-cs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sunil-lakshman Can you please add tests for this case?

github-advanced-security[bot]
github-advanced-security bot found potential problems Nov 29, 2024
View reviewed changes
test/entry/findone.js Dismissed Show dismissed Hide dismissed
@sunil-lakshman sunil-lakshman merged commit dafe4d3 into development Dec 2, 2024
7 checks passed
@sunil-lakshman sunil-lakshman deleted the Enh/dx-1826-http-code branch December 2, 2024 04:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nadeem-cs nadeem-cs nadeem-cs approved these changes

@harshithad0703 harshithad0703 Awaiting requested review from harshithad0703

@cs-raj cs-raj Awaiting requested review from cs-raj

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sunil-lakshman @nadeem-cs