Added support for pagination, GCP support and package bump #113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
sunil-lakshman
commented
Jan 10, 2024
•
sunil-lakshman
commented
- Pagination Support
- GCP NA support
- Package bump
- Changed package name
nadeem-cs
approved these changes
Jan 10, 2024
There was a problem hiding this comment.
Approved.
@sunil-lakshman Please add API test cases for the added features.
@nadeem-cs Pagination Api testcases are added in both entries and assets |
nadeem-cs
requested changes
Jan 11, 2024
ishaileshmishra
suggested changes
Jan 18, 2024
There was a problem hiding this comment.
Hi @nadeem-cs and @sunil-lakshman,
Kindly note that the suggested import statement differs from the one specified in the comment. Please review the following:
Original:
import contentstack from '@contentstack/delivery'Suggested:
import contentstack from '@contentstack/delivery-sdk'
Done @ishaileshmishra & @nadeem-cs |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.