Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Support new REST preview service #100

Conversation

Deepak-Kharah
Copy link
Contributor

The REST preview service introduces its own preview token and API endpoint for Live preview. This values will be used to fetch entry data for live preview.

Replaced "api.contentstack.io" to "rest-preview.contentstack.com" and replaced management_token to preview_token

fixes: https://contentstack.atlassian.net/browse/VC-311

The REST preview service introduces its own preview token and API
endpoint for Live preview. This values will be used to fetch entry data
for live preview.

Replaced "api.contentstack.io" to "rest-preview.contentstack.com" and
replaced `management_token` to `preview_token`

fixes: https://contentstack.atlassian.net/browse/VC-311
@Deepak-Kharah Deepak-Kharah requested a review from a team as a code owner October 23, 2023 07:18
Copy link
Member

@ishaileshmishra ishaileshmishra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please include both Unit and API tests to cover the live preview updates? @Deepak-Kharah

@Deepak-Kharah
Copy link
Contributor Author

I have added the test cases

Copy link
Member

@ishaileshmishra ishaileshmishra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

After it goes live, we will need to include API tests. For now, it appears satisfactory to me.

thanks @Deepak-Kharah ,

Deepak-Kharah and others added 15 commits November 8, 2023 19:03
The interface `LivePreivewConfigWithPreviewToken` should be
`LivePreviewConfigWithPreviewToken`
The live editor handles the references in the backend. So, we no longer
need them in the SDK. Moreover the live editor can handle multiple content
types and the optimization could break them.

fixes: https://contentstack.atlassian.net/browse/EB-749
…ptimization

feat: remove live preview optimization for live editor
…ptimization

Eb 749 remove live preview optimization
* Updated X-User-Agent header (contentstack#109)

* feat: added taxonomies url

* fix: updated dependencies and settings to fix npm install and build warnings

* fix: added fix for ESM module cannot use module.exports issue

* WIP: added taxonomy files

* fix: updated talismanrc

* feat: added taxonomies url

* WIP: taxonomy tests

* feat: added , ,  and  for taxonomy query

* feat: version bump

* refactor: moved _extend

* fix: updated .talismanrc

* fix: added fixes for failing asset tests

* fix: corrected content-types for tests

* fix: removed .only from test, so that all tests may execute

* fix: fixed existing tests

* fix: fixed taxonomies url, levels param and added doc

* WIP: added integration test cases

* fix: added unit tests

* fix: added unit tests

* fix: corrected test prefix and content-type uid

* fix: bumped patch version and updated lock file

* fix: removed commented tests

* fix: removed unused file, updated description

* fix: corrected package version

* feat: added gcp_na region

* feat: updated talismanrc

* fix: updated minor version

* fix: replaced Taxonomies().Query() with Taxonomies()

* fix: updated tests and types

* Bug/cs 40045 x user agent (contentstack#108)

* Updated X-User-Agent header

* Updated the X-User-Agent

* fix: fixed vulnerabilities

---------




* Upgraded node version in github workflow file (contentstack#116)

* feat: added taxonomies url

* fix: updated dependencies and settings to fix npm install and build warnings

* fix: added fix for ESM module cannot use module.exports issue

* WIP: added taxonomy files

* fix: updated talismanrc

* feat: added taxonomies url

* WIP: taxonomy tests

* feat: added , ,  and  for taxonomy query

* feat: version bump

* refactor: moved _extend

* fix: updated .talismanrc

* fix: added fixes for failing asset tests

* fix: corrected content-types for tests

* fix: removed .only from test, so that all tests may execute

* fix: fixed existing tests

* fix: fixed taxonomies url, levels param and added doc

* WIP: added integration test cases

* fix: added unit tests

* fix: added unit tests

* fix: corrected test prefix and content-type uid

* fix: bumped patch version and updated lock file

* fix: removed commented tests

* fix: removed unused file, updated description

* fix: corrected package version

* feat: added gcp_na region

* feat: updated talismanrc

* fix: updated minor version

* fix: replaced Taxonomies().Query() with Taxonomies()

* fix: updated tests and types

* Bug/cs 40045 x user agent (contentstack#108)

* Updated X-User-Agent header

* Updated the X-User-Agent

* fix: fixed vulnerabilities

* Fix/ghwf issuefix (contentstack#115)

* Updated X-User-Agent header (contentstack#109)

* feat: added taxonomies url

* fix: updated dependencies and settings to fix npm install and build warnings

* fix: added fix for ESM module cannot use module.exports issue

* WIP: added taxonomy files

* fix: updated talismanrc

* feat: added taxonomies url

* WIP: taxonomy tests

* feat: added , ,  and  for taxonomy query

* feat: version bump

* refactor: moved _extend

* fix: updated .talismanrc

* fix: added fixes for failing asset tests

* fix: corrected content-types for tests

* fix: removed .only from test, so that all tests may execute

* fix: fixed existing tests

* fix: fixed taxonomies url, levels param and added doc

* WIP: added integration test cases

* fix: added unit tests

* fix: added unit tests

* fix: corrected test prefix and content-type uid

* fix: bumped patch version and updated lock file

* fix: removed commented tests

* fix: removed unused file, updated description

* fix: corrected package version

* feat: added gcp_na region

* feat: updated talismanrc

* fix: updated minor version

* fix: replaced Taxonomies().Query() with Taxonomies()

* fix: updated tests and types

* Bug/cs 40045 x user agent (contentstack#108)

* Updated X-User-Agent header

* Updated the X-User-Agent

* fix: fixed vulnerabilities

---------




* Upgraded the working nodejs version in GH workflows

---------




---------




---------

Co-authored-by: Nadeem <[email protected]>
Co-authored-by: Abhinav Gupta <[email protected]>
Co-authored-by: abhinav <[email protected]>
Co-authored-by: Aravind Kumar <[email protected]>
@harshithad0703 harshithad0703 changed the base branch from master to next January 19, 2024 13:14
@harshithad0703 harshithad0703 marked this pull request as draft January 19, 2024 13:17
@abhinav-from-contentstack
Copy link
Contributor

Hi @ishaileshmishra, I have merged changes from @Deepak-Kharah's branch to v3-next branch and have resolved merge conflicts in #127 .
Can we close this PR?
cc : @harshithad0703

@abhinav-from-contentstack abhinav-from-contentstack merged commit e29ecc8 into contentstack:next Jan 24, 2024
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants