Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

container_build.sh works on MAC #590

Merged
merged 1 commit into from
Jan 15, 2025
Merged

Conversation

rhatdan
Copy link
Member

@rhatdan rhatdan commented Jan 14, 2025

Summary by Sourcery

Build:

  • Invoke container_build.sh on all platforms during build.

Signed-off-by: Daniel J Walsh <[email protected]>
Copy link
Contributor

sourcery-ai bot commented Jan 14, 2025

Reviewer's Guide by Sourcery

This pull request updates the Makefile to remove the OS check before calling container_build.sh. This allows the script to be used on macOS.

Flow diagram for updated build process compatibility

graph TD
    A[Start Build] --> B{Call container_build.sh}
    B --> C[Build Image]
    C --> D[End Build]

    style B fill:#90EE90,stroke:#333,stroke-width:2px
    note[Note: OS check removed<br/>Now works on both Linux and macOS]
    note --> B
Loading

File-Level Changes

Change Details Files
Removed OS check before calling container_build.sh.
  • Removed the ifeq ($(OS),Linux) and corresponding endif statements around the calls to container_build.sh in the build and build_rm targets.
  • This change allows the container_build.sh script to be called on macOS as well as Linux.
Makefile

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time. You can also use
    this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @rhatdan - I've reviewed your changes - here's some feedback:

Overall Comments:

  • Please include the changes made to container_build.sh that enable Mac support - they're necessary to review this PR properly.
  • The commit message should explain what changes were made to enable Mac support and any potential impacts on existing Linux builds.
Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@ericcurtin ericcurtin merged commit 87fc5d7 into containers:main Jan 15, 2025
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants