-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Looks like RHEL9 doesn't support autochangelog #560
base: main
Are you sure you want to change the base?
Conversation
Reviewer's Guide by SourceryThis pull request reverts the changelog generation method from automatic to manual. This change was made due to RHEL9 incompatibility with the automatic changelog generation tool. State diagram for changelog generation process changestateDiagram-v2
[*] --> AutomaticChangelog: Initial State
AutomaticChangelog --> ManualChangelog: RHEL9 Incompatibility
ManualChangelog --> [*]
state ManualChangelog {
[*] --> AddEntry
AddEntry --> FormatEntry: Add timestamp, author, version
FormatEntry --> [*]
}
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
If my reading of the build failures are correct on the main branch, RHEL9 doesn't support autochangelog, EPEL9 seems to though |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @ericcurtin - I've reviewed your changes - here's some feedback:
Overall Comments:
- Please provide a more detailed commit message explaining why autochangelog needs to be disabled (e.g., RHEL9 compatibility requirements)
- Consider using conditional logic to only disable autochangelog for RHEL9 builds while maintaining it for other distributions that support it
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Change back to manual changelogs Signed-off-by: Eric Curtin <[email protected]>
f91d6bf
to
c3903f4
Compare
@lsm5 could we get centos-stream-9 packit builds turned on for PRs so we don't get into the scenario where main is failing but PRs are passing again? |
Change back to manual changelogs
Summary by Sourcery
Build: