Adding test metadata for validators #698
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gjacobRH
requested review from
rhatdan,
lsm5,
dougsland,
Yarboa,
sandrobonazzola,
nsednev,
aesteve-rh,
pengshanyu and
kleinffm
as code owners
Yarboa
previously approved these changes
Jan 7, 2025
There was a problem hiding this comment.
In geeral, LGTM, need to review test failures
I prefer @pengshanyu to approve this one also
@gjacobRH please review errors below, and fix what ever needed
Please review shellcheck here
https://github.com/containers/qm/actions/runs/12636005381/job/35247817442
And DCO error
|
@Yarboa I believe the issues are now resolved and that all pre-commit checks are passing. |
|
LGTM, pending @pengshanyu review. |
pengshanyu
reviewed
Jan 8, 2025
tests/ffi/attempts_to_access_forbidden_file_system_resource/devices/check_dev_console.fmf
Outdated
Show resolved
Hide resolved
pengshanyu
reviewed
Jan 8, 2025
tests/ffi/attempts_to_access_forbidden_file_system_resource/devices/check_dev_disk.fmf
Outdated
Show resolved
Hide resolved
pengshanyu
reviewed
Jan 8, 2025
tests/ffi/attempts_to_access_forbidden_file_system_resource/devices/check_dev_kmsg.fmf
Outdated
Show resolved
Hide resolved
pengshanyu
reviewed
Jan 8, 2025
tests/ffi/attempts_to_access_forbidden_file_system_resource/regular_os_files/check_etc_qm.fmf
Outdated
Show resolved
Hide resolved
pengshanyu
reviewed
Jan 8, 2025
.../ffi/attempts_to_access_forbidden_file_system_resource/regular_os_files/check_usr_lib_qm.fmf
Outdated
Show resolved
Hide resolved
pengshanyu
reviewed
Jan 8, 2025
...fi/attempts_to_access_forbidden_file_system_resource/regular_os_files/check_usr_share_qm.fmf
Outdated
Show resolved
Hide resolved
pengshanyu
reviewed
Jan 8, 2025
...fi/attempts_to_access_forbidden_file_system_resource/regular_os_files/check_usr_share_qm.fmf
Outdated
Show resolved
Hide resolved
pengshanyu
reviewed
Jan 8, 2025
tests/ffi/attempts_to_access_forbidden_file_system_resource/sockets/check_run_udev_control.fmf
Outdated
Show resolved
Hide resolved
pengshanyu
reviewed
Jan 8, 2025
|
LGTM. |
|
/packit test --identifier qm-tier-0 |
|
@gjacobRH can you please squash all commits to one? |
Signed-off-by: George Jacob <[email protected]> Removed trailing spaces Signed-off-by: George Jacob <[email protected]> Fixed spacing and spelling issues Signed-off-by: George Jacob <[email protected]>
|
@Yarboa I've squashed the commits and the pre-commit checks are still passing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test metadata information was added to the following cases: