Adding comments for container options in qm.container #678
Conversation
Signed-off-by: Ilia Markelov <[email protected]>
ilimarx
force-pushed
the
qm_container_doc
branch
from
c5f38a8 to
0b5ca68
Compare
| @@ -35,10 +35,24 @@ LimitNOFILE=65536 | |||
| TasksMax=50% | |||
|
|
|||
| [Container] | |||
| # AddCapability | |||
There was a problem hiding this comment.
I would recommend here to use man quadlet also for details
There was a problem hiding this comment.
Tried to copy some details from man quadlet, hope it's better now
There was a problem hiding this comment.
Consider adding this link to upstream doc
https://docs.podman.io/en/v4.4/markdown/podman-systemd.unit.5.html#addcapability
for each Capability
Or that one, it is more accurate
man quadlet | awk '/AddCapability=$/,/^$/'
MHO it more accurate then copy paste content of changing description.
It could also be automated to check if parameters were changed,
I mean file parameters vs existence in manual
| # AddCapability | ||
| # ------------- | ||
| # Grants all capabilities to the container, increasing flexibility but significantly | ||
| # reducing security. | ||
| AddCapability=all |
qm.container
Outdated
| # Unmask | ||
| # ------- | ||
| # Unmasks all systemd services for the container, overriding masking that prevents | ||
| # access to specific services. |
qm.container
Outdated
|
|
||
| # Rootfs | ||
| # ------ | ||
| # Defines the root filesystem location for the container. |
There was a problem hiding this comment.
I would specify the QM rootfs partition
There was a problem hiding this comment.
I've specified the default path for rootfs
There was a problem hiding this comment.
see lower explanation related the usage of container
| # Rootfs | ||
| # ------ | ||
| # Defines the root filesystem location for the container. | ||
| # The '${ROOTFS}' variable should point to a valid filesystem path. | ||
| Rootfs=${ROOTFS} |
There was a problem hiding this comment.
see previous one is it a container or partitioned filesystem?
There was a problem hiding this comment.
Not sure what you mean here. Please check the changes
There was a problem hiding this comment.
Sure, I will try to explain there is a difference between running containerized podman and podman as part of file system
So in QM, container tools enables process isolation in the save filesystem and filesystem partition is isolated by disks
This i why it looks to me more logical to use disk instead of container
Consider using this
Defines the root filesystem location for QM partition.
instead
Defines the root filesystem location for the container.
No description provided.