Fix asurascans #572
Merged
Fix asurascans #572
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
riimuru
reviewed
Aug 8, 2024
There was a problem hiding this comment.
@ReneAslanov Thank you for the pr! is Asurascans no longer blocks requests using cloudflare? 🤔
I was surprised aswell but their new domain does not seem to be protected by cloudflare, atleast I did not encounter any issues scraping the data. On an unrelated note, is there anything I can do to make the "Compile TS / build" not fail? It looks like the bot cannot access my git repository. |
|
@ReneAslanov, I'm not sure how to approach the problem for that workflow. I want it to automatically push the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
This PR fixes asurascans as it was not working anymore.
Did you add tests for your changes?
Yes I did.
If relevant, did you update the documentation?
I added the missing documentation for it.
Summary
Since codeblitz97 asked me to add documentation for the remaining providers that don't already have them, I started by checking whether they work or not. Turns out the missing 3 (asurascans, comick, flamescans) all failed their tests, so I started by fixing asurascans and then added docs to it.
I might do comick next, however flamescans does not seem to exist anymore. It links to a Google Play Manga app called Comikey.