Fix(zoro): update the extractor in fetchEpisodeSources and update zoro domain. #482
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
riimuru
requested changes
Mar 3, 2024
src/extractors/megacloud.ts
Outdated
| server: number; | ||
| }; | ||
|
|
||
| class MegaCloud { |
There was a problem hiding this comment.
Can you extend VideoExtractor here so then you can override the extract function and use this.client.get instead of axios.get, use other extractors as a reference.
There was a problem hiding this comment.
Check the new commit.
riimuru
requested changes
Mar 3, 2024
src/extractors/megacloud.ts
Outdated
| default?: boolean; | ||
| }; | ||
|
|
||
| type intro_outro = { |
There was a problem hiding this comment.
This type isn't needed, use Intro imported from models instead.
There was a problem hiding this comment.
Check the new commit.
src/extractors/megacloud.ts
Outdated
| megacloud.script.concat(Date.now().toString()) | ||
| ); | ||
|
|
||
| text = data; |
There was a problem hiding this comment.
change to const test = data;
There was a problem hiding this comment.
Check the new commit.
riimuru
approved these changes
Mar 4, 2024
This was referenced Sep 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
URL: /anime/zoro/watch?episodeId=...
Change class: rapidcloud.ts to: megacloud.ts
Reason: rapidcloud.ts class used static keys from a repository that no longer work. I replaced it with a class that extracts the decryption keys from the same code.
Use as a base this extractor code and adapt it to the consumet.ts
Did you add tests for your changes?
No, tests already exist.
Summary
Other information