Set default value of evaluation_cost to 0 in BaseMetric class #1263
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #1262 The evaluate() method of GEval derived from BaseMetric was raising a TypeError: unsupported operand type(s) for +=: 'NoneType' and 'int/float' when called directly (without a prior call to measure()). This was due to the evaluation_cost attribute being initialized to None in the BaseMetric class.
self.evaluation_cost += costThis throws an error as evaluation_cost is None by default in BaseMetric class and cost is a float.This PR initializes evaluation_cost to 0 in the BaseMetric attributes, preventing the TypeError and allowing evaluate() to be called directly without issues.