GH-99: include types and check types #1224
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… toml, remove setup py setup files will automatically be taken care of by running ``` poetry build poetry publish ``` or both at once with ``` poetry publish --build ``` source: https://python-poetry.org/docs/cli#publish
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
builds on: GH-1223
resolves: GH-99
source: https://safjan.com/the-importance-of-adding-py-typed-file-to-your-typed-package/
note:
The types aren't currently checks so it is expected that there are some errors in the type check task.
Adding this as a check is a step towards making the types valid, and they can be progressively updated until the check does pass.