-
-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ARM OSX Migrator #55
ARM OSX Migrator #55
Conversation
…nda-forge-pinning 2022.10.07.16.50.25
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
Looks like Linux CI is failing due to this line /home/conda/feedstock_root/build_artifacts/z5py_1665162665392/work/include/z5/types/types.hxx:402:22: error: 'cout' is not a member of 'std'
402 | std::cout << val.type_name() << std::endl;
| ^~~~
In file included from /home/conda/feedstock_root/build_artifacts/z5py_1665162665392/work/include/z5/handle.hxx:4,
from /home/conda/feedstock_root/build_artifacts/z5py_1665162665392/work/include/z5/attributes.hxx:3,
from /home/conda/feedstock_root/build_artifacts/z5py_1665162665392/work/src/python/lib/attributes.cxx:4:
/home/conda/feedstock_root/build_artifacts/z5py_1665162665392/work/include/z5/types/types.hxx:9:1: note: 'std::cout' is defined in header '<iostream>'; did you forget to '#include <iostream>'?
8 | #include "nlohmann/json.hpp"
+++ |+#include <iostream>
9 | |
The master branch has an include of |
While it is in the latest branch, it does not appear to be in a release. So one would either need to:
|
@constantinpape Is this something you'll have the time to do? I don't think as an outsider to your project I'm equipped to cut a release for you :) |
Of course, I can do a release ;). Will draft it right away. |
And thanks for looking into this! And I am happy to help out! Just don't have time to do anything major right now / things that where I first need to investigate how to do it. |
That's true. Though one thing you could try, which would likely help Constantin, would be to open a PR here that tries building the latest Edit: Oops Constantin was way faster at replying than I thought 😅 |
Yeah, messages came just in when I was checking mails :) |
The bot just opened PR ( #56 ) for the release. Assuming that passes, once it is merged, this PR and any other bot PR will be regenerated on top of that change, which should hopefully fix this issue |
@jakirkham @pgunn everything was fine in #56 and I have just merged it. So hopefully we just have to wait for the regenerated PR. |
I see that this PR has conflicts, and I'm the only committer. I'm going to close this PR and will make another one as appropriate. This was generated by https://github.com/regro/autotick-bot/actions/runs/3210846913 |
Completed in PR ( #57 ) |
This feedstock is being rebuilt as part of the ARM OSX migration.
Feel free to merge the PR if CI is all green, but please don't close it
without reaching out the the ARM OSX team first at @conda-forge/help-osx-arm64.
If this PR was opened in error or needs to be updated please add the
bot-rerun
label to this PR. The bot will close this PR and schedule another one. If you do not have permissions to add this label, you can use the phrase@conda-forge-admin, please rerun bot
in a PR comment to have theconda-forge-admin
add it for you.This PR was created by the regro-cf-autotick-bot. The regro-cf-autotick-bot is a service to automatically track the dependency graph, migrate packages, and propose package version updates for conda-forge. Feel free to drop us a line if there are any issues! This PR was generated by https://github.com/regro/autotick-bot/actions/runs/3206191653, please use this URL for debugging.
Closes constantinpape/z5#211