Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lets release zarr since we patched python-elf #31

Merged

Conversation

conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-webservice.

I've started rerendering the recipe as instructed in #30.

If I find any needed changes to the recipe, I'll push them to this PR shortly. Thank you for waiting!

Here's a checklist to do before merging.

Fixes #30

@conda-forge-admin
Copy link
Contributor Author

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

@conda-forge-admin conda-forge-admin marked this pull request as ready for review January 11, 2025 21:45
@hmaarrfk hmaarrfk changed the title MNT: rerender Lets release zarr since we patched python-elf Jan 11, 2025
@hmaarrfk
Copy link
Contributor

sometimes things take an hour or so to propagate so we should check that zarr 3 isn't actually installed.

@anwai98
Copy link
Contributor

anwai98 commented Jan 11, 2025

Hi @hmaarrfk,

The latest zarr compatibility in elf is yet to be taken care of from our side: constantinpape/elf#114. I think we should stick with pinning version for zarr, for now!

@hmaarrfk
Copy link
Contributor

hmaarrfk commented Jan 11, 2025

Today. Elf with conda forge will not be coinstalled with zarr 3. As determined by constraints in that package itself.

So the code and comments here don't even apply to the micro Sam package.

They are relevant to python-elf. But Constantine and i applied the patches there so these are redundant and confusing.

Unless there is code in micro Sam directly that required zarr 2 functionality this should be merged for simplicity.

(Iphone keyboard is just terrible for code sorry)

@constantinpape
Copy link
Contributor

I looked into it further, and we actually need to pin zarr < 3 for micro_sam as well.
See computational-cell-analytics/micro-sam#830 for details.

I will keep the pin, but remove the extra version specifier here.

recipe/meta.yaml Outdated Show resolved Hide resolved
@constantinpape constantinpape merged commit d850209 into conda-forge:main Jan 12, 2025
4 checks passed
@hmaarrfk
Copy link
Contributor

Ok thanks.

We will need to "patch" the old releases to have this contraint too.

Maybe you can submit a patch like: conda-forge/conda-forge-repodata-patches-feedstock#941 and I can review it to merge it in.

@constantinpape
Copy link
Contributor

@hmaarrfk
Copy link
Contributor

Done here: conda-forge/conda-forge-repodata-patches-feedstock#943

Thanks without this, the set of rules becomes highly inconsistent and then this "limit" eventually gets ignored by end users.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

@conda-forge-admin please rerender
4 participants