Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sort sso profiles by profile name #7

Merged
merged 2 commits into from
Aug 13, 2024
Merged

sort sso profiles by profile name #7

merged 2 commits into from
Aug 13, 2024

Conversation

shwethaumashanker
Copy link
Contributor

@shwethaumashanker shwethaumashanker commented Aug 12, 2024 •
edited
Loading

The previous implementation only sorts role names, in cases with multiple accounts this code sorts according to account name and role name.

Tested locally in the granted repo

@shwethaumashanker shwethaumashanker marked this pull request as ready for review August 12, 2024 21:24
@shwethaumashanker shwethaumashanker changed the title sort profiles by profile name sort sso profiles by profile name Aug 12, 2024
chrnorm
chrnorm requested changes Aug 12, 2024
View reviewed changes
Copy link
Contributor

@chrnorm chrnorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you please add a new test case to cover this behavior? There is a pattern you can follow for this in the test file

@shwethaumashanker shwethaumashanker merged commit 1ead8fd into main Aug 13, 2024
2 checks passed
@shwethaumashanker shwethaumashanker deleted the sort-SSO-profiles-alphabetically-fix branch August 13, 2024 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrnorm chrnorm chrnorm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shwethaumashanker @chrnorm