Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore project refinement #39

Merged
merged 6 commits into from
Dec 6, 2024
Merged

Chore project refinement #39

merged 6 commits into from
Dec 6, 2024

Conversation

DavidMorenoo
Copy link
Collaborator

This pull request includes several significant improvements to our project's architecture, security, and documentation.

HTTPS Upgrade: Transitioned the entire application from HTTP to HTTPS for enhanced security.

Environment File Management: Removed .env files from Git tracking and updated .gitignore to prevent accidental exposure of sensitive information.

Automatic Database Seeding: Implemented a mechanism for automatic database seeding on server start, improving development workflow and data consistency.

Architecture Refactoring: Modified the application architecture to separate concerns and adhere to MVC principles, enhancing maintainability and scalability.

Swagger Documentation: Set up the basic structure for Swagger documentation and added comprehensive annotations for the AuthController, improving API discoverability and usability.

-Update backend server configuration to use HTTPS
-Modify frontend API calls to use HTTPS endpoints
-Generate and implement SSL/TLS certificates
-Remove .env files from Git cache
-Add .env to .gitignore to prevent future tracking
Ensure sensitive information is no longer uploaded
-Create seeding scripts for initial data population
-Implement logic to check for existing data before seeding
-Add seeding process to server startup routine
-Create seed data for users, objects, and other essential entities
-Implement error handling and logging for seeding process
-Create @service layer to encapsulate business logic
-Move business logic from controllers to services
-Ensure controllers only interact with services, not repositories
-Restructure code to improve modularity and reduce coupling
-Initialize Swagger JSDoc and Swagger UI integration
-Create basic folder structure for API documentation
-Add swagger.js configuration file
-Set up initial swagger.js file
-Prepare controllers for Swagger annotations
-Add necessary dependencies for Swagger integration
-Create Swagger annotations for AuthController
-Document login endpoint with request/response schemas
-Add documentation for registration endpoint
-Include JWT token information in response examples
-Document error responses for authentication failures
-Ensure all auth endpoints are properly tagged and categorized
Copy link

sonarqubecloud bot commented Dec 6, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
4 Security Hotspots
10.5% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

@DavidMorenoo DavidMorenoo merged commit 3abc135 into main Dec 6, 2024
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant