add bot to channel when sending a reaction

codelittinc · Sep 27, 2024 · 27c119e · 27c119e
1 parent 6d5c288
commit 27c119e
Show file tree

Hide file tree

Showing 7 changed files with 31 additions and 24 deletions.
diff --git a/.rubocop_todo.yml b/.rubocop_todo.yml
@@ -1,21 +1,21 @@
 # This configuration was generated by
 # `rubocop --auto-gen-config`
-# on 2022-08-11 22:31:55 UTC using RuboCop version 1.34.1.
+# on 2024-09-27 17:34:39 UTC using RuboCop version 1.45.1.
 # The point is for the user to remove these configuration records
 # one by one as the offenses are removed from the code base.
 # Note that changes in the inspected code, or installation of new
 # versions of RuboCop, may require this file to be generated again.
 
-# Offense count: 1
-# Configuration parameters: CountComments, CountAsOne, ExcludedMethods, AllowedMethods, AllowedPatterns, IgnoredMethods.
+# Offense count: 2
+# Configuration parameters: CountComments, CountAsOne, AllowedMethods, AllowedPatterns.
 # AllowedMethods: refine
 Metrics/BlockLength:
   Max: 47
 
-# Offense count: 3
-# Configuration parameters: CountComments, CountAsOne, ExcludedMethods, AllowedMethods, AllowedPatterns, IgnoredMethods.
+# Offense count: 6
+# Configuration parameters: CountComments, CountAsOne, AllowedMethods, AllowedPatterns.
 Metrics/MethodLength:
-  Max: 12
+  Max: 13
 
 # Offense count: 1
 # Configuration parameters: CountKeywordArgs, MaxOptionalParameters.
@@ -24,7 +24,7 @@ Metrics/ParameterLists:
 
 # Offense count: 3
 # This cop supports safe autocorrection (--autocorrect).
-# Configuration parameters: AllowHeredoc, AllowURI, URISchemes, IgnoreCopDirectives, AllowedPatterns, IgnoredPatterns.
+# Configuration parameters: AllowHeredoc, AllowURI, URISchemes, IgnoreCopDirectives, AllowedPatterns.
 # URISchemes: http, https
 Layout/LineLength:
   Max: 122
diff --git a/app/services/admin/actions/replay_flow.rb b/app/services/admin/actions/replay_flow.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Admin
   module Actions
     class ReplayFlow < RailsAdmin::Config::Actions::Base
@@ -22,7 +24,7 @@ class ReplayFlow < RailsAdmin::Config::Actions::Base
 
       register_instance_option :controller do
         proc do
-          flash[:success] = "We're replaying this flow right now!"
+          flash[:success] = t('admin.actions.replay_flow.message')
           if Rails.env.production?
             HardWorker.perform_async(@object.id)
           else
@@ -34,4 +36,4 @@ class ReplayFlow < RailsAdmin::Config::Actions::Base
       end
     end
   end
-end
+end
diff --git a/app/services/clients/slack/channel.rb b/app/services/clients/slack/channel.rb
@@ -37,12 +37,6 @@ def list
         channels.map { |channel| channel.slice(:id, :name).to_h }.sort_by { |hash| hash['name'] }
       end
 
-      def join!(channel)
-        client.conversations_join({
-                                    channel:
-                                  })
-      end
-
       def remove_hash(channel)
         channel.gsub('#', '')
       end

diff --git a/app/services/clients/slack/client.rb b/app/services/clients/slack/client.rb
@@ -16,6 +16,14 @@ def client
 
         @client = ::Slack::Web::Client.new
       end
+
+      private
+
+      def join!(channel)
+        client.conversations_join({
+                                    channel:
+                                  })
+      end
     end
   end
 end
diff --git a/app/services/clients/slack/reaction.rb b/app/services/clients/slack/reaction.rb
@@ -6,18 +6,21 @@ module Clients
   module Slack
     class Reaction < Client
       def send!(channel, reaction, timestamp)
-        # @TODO: remove this cleaning from this method
         return unless timestamp
 
         channel = remove_hash(channel) if channel.upcase == channel
 
-        clean_reactions!(channel, timestamp)
-
-        client.reactions_add(
-          channel:,
-          name: reaction,
-          timestamp:
-        )
+        begin
+          clean_reactions!(channel, timestamp)
+          client.reactions_add(
+            channel:,
+            name: reaction,
+            timestamp:
+          )
+        rescue ::Slack::Web::Api::Errors::NotInChannel
+          join!(channel)
+          send!(channel, reaction, timestamp)
+        end
       end
 
       private

diff --git a/config/initializers/rails_admin.rb b/config/initializers/rails_admin.rb
@@ -50,7 +50,6 @@
     show_in_app
     replay_flow
 
-
     ## With an audit adapter, you can add:
     # history_index
     # history_show

diff --git a/config/locales/en.yml b/config/locales/en.yml
@@ -34,3 +34,4 @@ en:
     actions:
       replay_flow:
         menu: "Rerun flow"
+        message: "We're replaying this flow right now!"