add constraint to avoid creating duplicate time offs

codelittinc · Jun 13, 2024 · fd6afff · fd6afff
1 parent f43dd5b
commit fd6afff
Show file tree

Hide file tree

Showing 6 changed files with 25 additions and 9 deletions.
diff --git a/app/controllers/time_offs_controller.rb b/app/controllers/time_offs_controller.rb
@@ -10,7 +10,7 @@ def create
     end
 
     time_off = TimeOffBuilder.call(text, start_datetime, end_datetime)
-    time_off&.save
+    time_off&.save!
     success = time_off&.persisted?
     msg = success ? { id: time_off&.id } : 'The time of request creation failed'
 
@@ -44,6 +44,6 @@ def end_datetime
   end
 
   def time_off_params
-    params.require(:webhook_time_off).permit(:text, :start_datetime, :end_datetime).to_h
+    params.permit(:text, :start_datetime, :end_datetime).to_h
   end
 end
diff --git a/app/models/time_off.rb b/app/models/time_off.rb
@@ -14,8 +14,9 @@
 #
 # Indexes
 #
-#  index_time_offs_on_time_off_type_id  (time_off_type_id)
-#  index_time_offs_on_user_id           (user_id)
+#  index_time_offs_on_time_off_type_id    (time_off_type_id)
+#  index_time_offs_on_unique_combination  (starts_at,ends_at,time_off_type_id,user_id) UNIQUE
+#  index_time_offs_on_user_id             (user_id)
 #
 # Foreign Keys
 #
@@ -29,5 +30,9 @@ class TimeOff < ApplicationRecord
   validates :starts_at, presence: true
   validates :ends_at, presence: true
 
+  validates :user_id,
+            uniqueness: { scope: %i[starts_at ends_at time_off_type_id],
+                          message: 'Time off with the same start and end times already exists for this user and time off type' }
+
   scope :active_in_period, ->(start_date, end_date) { where('starts_at <= ? AND ends_at >= ?', end_date, start_date) }
 end
diff --git a/db/migrate/20240613151647_add_unique_index_to_time_offs.rb b/db/migrate/20240613151647_add_unique_index_to_time_offs.rb
@@ -0,0 +1,8 @@
+# frozen_string_literal: true
+
+class AddUniqueIndexToTimeOffs < ActiveRecord::Migration[7.0]
+  def change
+    add_index :time_offs, %i[starts_at ends_at time_off_type_id user_id], unique: true,
+                                                                          name: 'index_time_offs_on_unique_combination'
+  end
+end
diff --git a/db/schema.rb b/db/schema.rb
diff --git a/spec/factories/time_offs.rb b/spec/factories/time_offs.rb
@@ -14,8 +14,9 @@
 #
 # Indexes
 #
-#  index_time_offs_on_time_off_type_id  (time_off_type_id)
-#  index_time_offs_on_user_id           (user_id)
+#  index_time_offs_on_time_off_type_id    (time_off_type_id)
+#  index_time_offs_on_unique_combination  (starts_at,ends_at,time_off_type_id,user_id) UNIQUE
+#  index_time_offs_on_user_id             (user_id)
 #
 # Foreign Keys
 #

diff --git a/spec/models/time_off_spec.rb b/spec/models/time_off_spec.rb
@@ -14,8 +14,9 @@
 #
 # Indexes
 #
-#  index_time_offs_on_time_off_type_id  (time_off_type_id)
-#  index_time_offs_on_user_id           (user_id)
+#  index_time_offs_on_time_off_type_id    (time_off_type_id)
+#  index_time_offs_on_unique_combination  (starts_at,ends_at,time_off_type_id,user_id) UNIQUE
+#  index_time_offs_on_user_id             (user_id)
 #
 # Foreign Keys
 #