Officer UI #309
Merged
Officer UI #309
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
not integrated with API, just visuals
|
Updated the snapshots which should fix the tests. Looks good! And gives us some structure to work with when designing the Officer API. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request introduces several enhancements by @abelaba and myself to the officer search functionality, including the integration of the current repository's data table component for building a search results table for the officer results and the addition of a new bubble chart component for the officer result's data visualization. Additionally, it addresses various visual bugs and implements design updates according to the Figma specifications.
Changes
1. Officer Search Results Table
Utilized the current repository's data table component to construct a search results table for the officer search functionality.
2. Add BubbleChart Component
Created a BubbleChart component for visualizing officer search result data, closely aligned with Figma implementation.
3. Adjust Donate Button Position
Relocated the donate button to the right side of the header component for improved visibility and alignment.
4. Update Search Form Visuals
Adding additional information to each search form input, closely aligned with Figma specifications.
5. Error Alert Dialog Component
Introduced an error alert dialog component to provide users with clear and informative error messages.
Screenshots
Additional Notes
The results table and bubble chart components currently use placeholder data. We'll be working on implementing the API for full functionality this upcoming week, and looking into using the proper schemas for that implementation as well.