Impliment deepcode suggestions (#42)

codecov · Feb 22, 2021 · 83d0664 · 83d0664
1 parent 7b2c1e6
commit 83d0664
Show file tree

Hide file tree

Showing 5 changed files with 8 additions and 7 deletions.
diff --git a/.gitignore b/.gitignore
@@ -69,3 +69,4 @@ codecov-macos
 codecov.exe
 .DS_Store
 .idea/*
+.dccache
diff --git a/src/ci_providers/provider_circleci.js b/src/ci_providers/provider_circleci.js
@@ -65,7 +65,7 @@ function getServiceParams(inputs) {
     commit: _getSHA(inputs),
     job: _getJob(inputs.envs),
     pr: _getPR(inputs),
-    service: _getService(inputs),
+    service: _getService(),
     slug: _getSlug(inputs)
   };
 }

diff --git a/src/helpers/web.js b/src/helpers/web.js
@@ -24,8 +24,7 @@ async function uploadToCodecovPUT(uploadURL, uploadFile) {
       .retry()
       .send(uploadFile) // sends a JSON post body
       .set("Content-Type", "application/x-gzip")
-      .set("Content-Encoding", "gzip")
-      .set("Content-Length", Buffer.byteLength(uploadFile));
+      .set("Content-Encoding", "gzip");
 
     if (result.status === 200) {
       return { status: "success", resultURL: codecovResultURL };
@@ -45,8 +44,7 @@ async function uploadToCodecov(uploadURL, token, query, uploadFile, version) {
       .retry()
       .send(uploadFile) // sends a JSON post body
       .set("X-Reduced-Redundancy", "false")
-      .set("X-Content-Type", "application/x-gzip")
-      .set("Content-Length", Buffer.byteLength(uploadFile));
+      .set("X-Content-Type", "application/x-gzip");
 
     return result.res.text;
   } catch (error) {

diff --git a/src/index.js b/src/index.js
@@ -146,8 +146,7 @@ async function main(args) {
       );
       const result = await webHelpers.uploadToCodecovPUT(
         uploadURL,
-        gzippedFile,
-        inputs
+        gzippedFile
       );
       console.log(result);
     }

diff --git a/test/helpers/web.test.js b/test/helpers/web.test.js
@@ -16,6 +16,7 @@ describe("Web Helpers", function() {
     query = "hello";
     version = "0.0.1";
 
+      // deepcode ignore WrongNumberOfArgs/test: believe this is a false positive
       nock("https://codecov.io")
       .put("/")
       .query(true)
@@ -29,6 +30,7 @@ afterEach(function() {
 
   it("Can POST to the uploader endpoint (HTTP)", async function() {
     uploadURL = "http://codecov.io";
+    // deepcode ignore WrongNumberOfArgs/test: believe this is a false positive
     nock("http://codecov.io")
     .post("/upload/v4")
     .query(true)
@@ -51,6 +53,7 @@ afterEach(function() {
 
   it("Can POST to the uploader endpoint (HTTPS)", async function() {
     uploadURL = "https://codecov.io";
+    // deepcode ignore WrongNumberOfArgs/test: believe this is a false positive
     nock("https://codecov.io")
     .post("/upload/v4")
     .query(true)