Merge pull request #331 from tagatac/fix-nan

Convert NaN PR numbers to the empty string
codecov · Aug 23, 2021 · 7ee76e0 · 7ee76e0
2 parents f6b7909 + 53ba78c
commit 7ee76e0
Show file tree

Hide file tree

Showing 2 changed files with 20 additions and 1 deletion.
diff --git a/src/helpers/web.ts b/src/helpers/web.ts
@@ -111,7 +111,7 @@ export async function uploadToCodecov(
  */
 export function generateQuery(queryParams: IServiceParams): string {
   checkValueType('pr', queryParams.pr, 'number')
-  if (queryParams.pr === 0) {
+  if (queryParams.pr === 0  || isNaN(Number(queryParams.pr))) {
     queryParams.pr = ''
   }
   return Object.entries(queryParams)

diff --git a/test/helpers/web.test.ts b/test/helpers/web.test.ts
@@ -93,6 +93,25 @@ describe('Web Helpers', () => {
     )
   })
 
+  it('NaN PR numbers are not propagated to the query', () => {
+    const queryParams: IServiceParams  = {
+      branch: 'testBranch',
+      commit: 'commitSHA',
+      build: '4',
+      buildURL: 'https://ci-providor.local/job/xyz',
+      name: 'testName',
+      tag: 'tagV1',
+      slug: 'testOrg/testRepo',
+      service: 'testingCI',
+      flags: 'unit,uploader',
+      pr: NaN,
+      job: '6',
+    }
+    expect(generateQuery(queryParams)).toBe(
+      'branch=testBranch&commit=commitSHA&build=4&build_url=https://ci-providor.local/job/xyz&name=testName&tag=tagV1&slug=testOrg/testRepo&service=testingCI&flags=unit,uploader&pr=&job=6',
+    )
+  })
+
   it('can populateBuildParams() from args', () => {
     const result = populateBuildParams(
       { args: { flags: 'testFlag', tag: 'testTag' }, environment: {} },