Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

포인트 상품 구매 response 및 request 수정 & notification_seq 버그 수정 #65

Merged
merged 3 commits into from
Oct 24, 2023
Merged

포인트 상품 구매 response 및 request 수정 & notification_seq 버그 수정 #65

merged 3 commits into from
Oct 24, 2023

Conversation

13wjdgk
Copy link
Contributor

@13wjdgk 13wjdgk commented Oct 24, 2023 •
edited
Loading

Changes 📝

  • 포인트 상품 구매 response,reqeust 수정
  • 'notification_seq 찾을 수 없음' 버그 수정

Details 🌼

  • 포인트 상품 구매 수정
    • 포인트 구매시 사용자의 이름과 간단한 평가를 추가로 요청 받습니다.
    • 위의 변경사항으로 request와 response 가 수정되었습니다
  • notification_seq 버그 수정
    • notification_seq 테이블을 찾을 수 없다는 오류가 발생하였습니다.
    • 원인 : notification_seq 테이블은 notification Id를 GeneratedValue.Auto로 설정하여 시퀀스 값이 선택되었는데, mysql은 시퀀스를 제공하지 않기 때문입니다.
    • 해결 : GeneratedValue.IDENTITY로 수정하였습니다

Check List ☑️

  • 테스트 코드를 통과했다.
  • merge할 브랜치의 위치를 확인했다. (main ❌)
  • Assignee를 지정했다.
  • Label을 지정했다.

@13wjdgk 13wjdgk added bug 버그 refactoring 리팩토링 labels Oct 24, 2023
@13wjdgk 13wjdgk self-assigned this Oct 24, 2023
@coniverse-github-app
Copy link

Passed

Analysis Details

0 Issues

  • Bug 0 Bugs
  • Vulnerability 0 Vulnerabilities
  • Code Smell 0 Code Smells

Coverage and Duplications

  • Coverage 100.00% Coverage (97.00% Estimated after merge)
  • Duplications 0.00% Duplicated Code (0.80% Estimated after merge)

Project ID: co-niverse_dangjang-backend_AYj2jZJELehUZAlqDvRk

View in SonarQube

GIVEN53
GIVEN53 approved these changes Oct 24, 2023
View reviewed changes
Copy link
Member

@GIVEN53 GIVEN53 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생했어요~

@GIVEN53 GIVEN53 merged commit 6bd0541 into dev Oct 24, 2023
1 check passed
@GIVEN53 GIVEN53 deleted the refactor/purchaseRequest branch November 6, 2023 06:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GIVEN53 GIVEN53 GIVEN53 approved these changes

Assignees

@13wjdgk 13wjdgk

Labels
bug 버그 refactoring 리팩토링
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@13wjdgk @GIVEN53