Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UserLog 추가 #62

Merged
merged 4 commits into from
Oct 20, 2023
Merged

UserLog 추가 #62

merged 4 commits into from
Oct 20, 2023

Conversation

13wjdgk
Copy link
Contributor

@13wjdgk 13wjdgk commented Oct 19, 2023 •
edited
Loading

Changes 📝

  • UserLog추가

Details 🌼

  • UserLog추가
    • 로깅에 필요한 User 정보를 UserLog에 담았습니다.
    • 홈 api(getDayGuide) response에 UserLog 추가하였습니다.
  • 포인트 동시 접속 테스트 제거
    • 포인트 동시 접속 테스트 수정을 위해 잠시 제거하였습니다. 포인트 도메인 조금 더 보완해서 다시 올릴게요 !

Check List ☑️

  • 테스트 코드를 통과했다.
  • merge할 브랜치의 위치를 확인했다. (main ❌)
  • Assignee를 지정했다.
  • Label을 지정했다.

@13wjdgk 13wjdgk added the refactoring 리팩토링 label Oct 19, 2023
@13wjdgk 13wjdgk self-assigned this Oct 19, 2023
@coniverse-github-app
Copy link

Passed

Analysis Details

0 Issues

  • Bug 0 Bugs
  • Vulnerability 0 Vulnerabilities
  • Code Smell 0 Code Smells

Coverage and Duplications

  • Coverage 100.00% Coverage (97.00% Estimated after merge)
  • Duplications 0.00% Duplicated Code (0.80% Estimated after merge)

Project ID: co-niverse_dangjang-backend_AYj2jZJELehUZAlqDvRk

View in SonarQube

GIVEN53
GIVEN53 approved these changes Oct 20, 2023
View reviewed changes
Copy link
Member

@GIVEN53 GIVEN53 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

빠른 PR 굿굿~

@GIVEN53 GIVEN53 merged commit 0808ef6 into dev Oct 20, 2023
1 check passed
@GIVEN53 GIVEN53 deleted the refactor/addUserLog branch October 23, 2023 06:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GIVEN53 GIVEN53 GIVEN53 approved these changes

Assignees

@13wjdgk 13wjdgk

Labels
refactoring 리팩토링
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@13wjdgk @GIVEN53