Skip to content

Commit

Permalink
Fix a reference to an undefined output in GitHub Actions
Browse files Browse the repository at this point in the history
  • Loading branch information
suzuki-shunsuke committed Oct 13, 2024
1 parent 6439a64 commit 671e3d8
Showing 1 changed file with 35 additions and 30 deletions.
65 changes: 35 additions & 30 deletions .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -10,13 +10,16 @@ on:
- main
- release/v*
paths-ignore:
- '.github/**'
- 'docs/**'
- 'examples/**'
- 'test/**'
- ".github/**"
- "docs/**"
- "examples/**"
- "test/**"

workflow_dispatch:

env:
TERRAFORM_VERSION: "1.9.7"

jobs:
# ensure the code builds...
build:
Expand Down Expand Up @@ -91,29 +94,29 @@ jobs:
needs: build
runs-on: ubuntu-latest
steps:
- name: Check out code
uses: actions/checkout@v4

- uses: hadolint/[email protected]
id: hadolint
with:
dockerfile: Dockerfile
failure-threshold: warning
format: sarif
output-file: hadolint.sarif
# https://github.com/hadolint/hadolint?tab=readme-ov-file#rules
# DL3008 Pin versions in apt-get install
ignore: DL3008

- name: Upload SARIF file
uses: github/codeql-action/upload-sarif@v3
if: always()
with:
# Path to SARIF file relative to the root of the repository
sarif_file: hadolint.sarif
# Optional category for the results (used to differentiate multiple results for one commit)
category: hadolint
wait-for-processing: true
- name: Check out code
uses: actions/checkout@v4

- uses: hadolint/[email protected]
id: hadolint
with:
dockerfile: Dockerfile
failure-threshold: warning
format: sarif
output-file: hadolint.sarif
# https://github.com/hadolint/hadolint?tab=readme-ov-file#rules
# DL3008 Pin versions in apt-get install
ignore: DL3008

- name: Upload SARIF file
uses: github/codeql-action/upload-sarif@v3
if: always()
with:
# Path to SARIF file relative to the root of the repository
sarif_file: hadolint.sarif
# Optional category for the results (used to differentiate multiple results for one commit)
category: hadolint
wait-for-processing: true

# run localstack demo tests
localstack:
Expand Down Expand Up @@ -159,7 +162,8 @@ jobs:

- uses: hashicorp/setup-terraform@v3
with:
terraform_version: "1.9.7"
terraform_version: ${{ env.TERRAFORM_VERSION }}
terraform_wrapper: false

- name: Run tests for ${{ matrix.demo-folder }}
run: |
Expand Down Expand Up @@ -268,7 +272,8 @@ jobs:

- uses: hashicorp/setup-terraform@v3
with:
terraform_version: "1.9.7"
terraform_version: ${{ env.TERRAFORM_VERSION }}
terraform_wrapper: false

- name: Run tests for ${{ matrix.demo-folder }}
run: |
Expand Down Expand Up @@ -309,7 +314,7 @@ jobs:
- name: Install Terraform
uses: hashicorp/setup-terraform@v3
with:
terraform_version: ${{ steps.config.outputs.terraform-version }}
terraform_version: ${{ env.TERRAFORM_VERSION }}
terraform_wrapper: false

- name: Lint examples/${{ matrix.demo-folder }}/components/terraform
Expand Down

0 comments on commit 671e3d8

Please sign in to comment.