Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(perf.tests) Use mTLS to send custom metrics #3445

Merged
merged 2 commits into from
Jan 15, 2025
Merged

fix(perf.tests) Use mTLS to send custom metrics #3445

merged 2 commits into from
Jan 15, 2025

Conversation

asalan316
Copy link
Contributor

@asalan316 asalan316 commented Jan 9, 2025 •
edited
Loading

Problem

  • Performance test were not running in the CI pipeline, although the job was green
  • Basic authentication (deprecated) is used to send custom metrics

Fix

  • Corrected make targets for performance tests
  • Use mTLS authentication to send custom metrics

@asalan316 asalan316 added the allow-acceptance-tests This label needs to be added to enable the acceptance tests to run. label Jan 9, 2025
@asalan316 asalan316 force-pushed the fix-peformance-test-in-ci branch 7 times, most recently from 797551c to 6e024da Compare January 13, 2025 14:05
@asalan316 asalan316 marked this pull request as ready for review January 13, 2025 14:05
@asalan316
use mTLS for custom metrics
b33c821 
remove acceptance-tests-config make target
@asalan316 asalan316 force-pushed the fix-peformance-test-in-ci branch from 6e024da to b33c821 Compare January 13, 2025 14:17
@asalan316 asalan316 changed the title fix performance test fix(Perf.Tests) Use mTLS to send custom metrics Jan 13, 2025
@asalan316 asalan316 changed the title fix(Perf.Tests) Use mTLS to send custom metrics fix(perf.tests) Use mTLS to send custom metrics Jan 13, 2025
@asalan316 asalan316 marked this pull request as draft January 13, 2025 15:11
@asalan316 asalan316 force-pushed the fix-peformance-test-in-ci branch from 37bbf54 to 0839ede Compare January 13, 2025 15:38
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@asalan316 asalan316 marked this pull request as ready for review January 13, 2025 15:39
@asalan316 asalan316 merged commit 0f28e8d into main Jan 15, 2025
40 of 44 checks passed
@asalan316 asalan316 deleted the fix-peformance-test-in-ci branch January 15, 2025 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@silvestre silvestre silvestre approved these changes

Assignees
No one assigned
Labels
allow-acceptance-tests This label needs to be added to enable the acceptance tests to run. bug chore
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@asalan316 @silvestre