Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Custom-Metrics: Set default_credential_type to x509 (mTLS) - Breaking Change #3439

Merged
merged 4 commits into from
Jan 9, 2025
Merged

Custom-Metrics: Set default_credential_type to x509 (mTLS) - Breaking Change #3439

merged 4 commits into from
Jan 9, 2025

Conversation

asalan316
Copy link
Contributor

@asalan316 asalan316 commented Jan 7, 2025 •
edited
Loading

  • Set default_credential_type to x509 (mTLS) - Breaking Change
  • Added test to check basic authentication route for custom metrics submission

However, basic authentication route can still be used (for some time) in the following ways:

  • Change the default_credential_type bosh property to binding-secret and trigger the autoscaler deployment
  • Specify credential-type as binding-secret during the service binding procress e.g., cf bind-service....

Other Fixes

  • Autoscaler lead time acceptance test now uses mTLS authentication to send custom metrics

@asalan316 asalan316 force-pushed the add-bndind-secret-test branch 2 times, most recently from 57ddefa to f60a24c Compare January 7, 2025 12:56
@asalan316 asalan316 added the allow-acceptance-tests This label needs to be added to enable the acceptance tests to run. label Jan 7, 2025
@asalan316 asalan316 changed the title Test Custom Metrics With Basic Authentication (binding-secret) chore(custom-metrics) Test Custom Metrics With Basic Authentication (binding-secret) Jan 7, 2025
@asalan316 asalan316 force-pushed the add-bndind-secret-test branch 3 times, most recently from 2c7ab93 to e7e32d7 Compare January 8, 2025 10:06
@asalan316 asalan316 removed the allow-acceptance-tests This label needs to be added to enable the acceptance tests to run. label Jan 8, 2025
@asalan316 asalan316 force-pushed the add-bndind-secret-test branch 2 times, most recently from 3ef960b to fd2dd8e Compare January 8, 2025 11:44
@asalan316 asalan316 added allow-acceptance-tests This label needs to be added to enable the acceptance tests to run. skip-cleanup and removed skip-cleanup allow-acceptance-tests This label needs to be added to enable the acceptance tests to run. labels Jan 8, 2025
@asalan316 asalan316 force-pushed the add-bndind-secret-test branch from 80d9424 to 1ba24f9 Compare January 8, 2025 14:29
@asalan316 asalan316 marked this pull request as ready for review January 8, 2025 16:18
@asalan316 asalan316 force-pushed the add-bndind-secret-test branch from 1ba24f9 to a013f4b Compare January 8, 2025 16:41
@asalan316 asalan316 changed the title chore(custom-metrics) Test Custom Metrics With Basic Authentication (binding-secret) chore(custom-metrics) Test Custom Metrics With Basic Authentication Jan 8, 2025
@asalan316 asalan316 changed the title chore(custom-metrics) Test Custom Metrics With Basic Authentication Custom-Metrics: Set default_credential_type to x509 (mTLS) - Breaking Change Jan 9, 2025
silvestre
silvestre approved these changes Jan 9, 2025
View reviewed changes
src/acceptance/app/custom_metric_test.go Outdated Show resolved Hide resolved
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Jan 9, 2025

Quality Gate Failed Quality Gate failed

Failed conditions
3.7% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

@asalan316 asalan316 merged commit 50854f5 into main Jan 9, 2025
35 of 36 checks passed
@asalan316 asalan316 deleted the add-bndind-secret-test branch January 9, 2025 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@silvestre silvestre silvestre approved these changes

Assignees
No one assigned
Labels
allow-acceptance-tests This label needs to be added to enable the acceptance tests to run. breaking-change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@asalan316 @silvestre