Allow benchmark shm-directory to use env-var #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added `derive_shm_path()` in benches/synchronizer.rs to allow override of default shared-mem directory (for platforms where that doesn't work out of the box)
|
LGTM. cc @austinhartzheim for review. |
|
Merged. Thanks for the contribution. We use |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added
derive_shm_path()in benches/synchronizer.rs to allow override of default shared-mem directory (for platforms where that doesn't work out of the box)Cloned onto a macOS box - actually two: one AMD and one Intel , with different versions of OS - and both experience same issue, which I drilled down to not having access into /dev/shm (under user account). This change allows a user to define environment variable
"MMAPSYNC_BM_ROOTDIR"to specify a custom benchmark root directory.Attempted to keep as succinct as surrounding code, while prompting if custom dir is wrong. Feel free to rip apart as you see fit. (Or, possibly, explain my misapprehension in the case where this change is not solving a real problem.)
HTH