This repository has been archived by the owner on Aug 30, 2024. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
CHANGES.md
) or test/build only changesDescription
Correct the list of valid replicator states
Fixes #464
Approach
failed
state tofollow_replication
since this is another condition under which it should exit in CouchDB 2.1+.Schema & API Changes
follow_replication
exits for theerror
state even though that is a retryable state in CouchDB 2.1+ systems, it was existing behaviour for Couch < 2.1. Using theerror
state as an exit condition is retained so the code continues to operate in the same way as it has since launch when interacting with CouchDB >=2.1 based servers.Behaviour change for the
failed
state which should have endedfollow_replication
but didn't, this is a fix.Security and Privacy
Testing
The replicator tests were missing some other states introduced in CouchDB 2.1 scheduler.
Monitoring and Logging