Skip to content
This repository has been archived by the owner on Aug 30, 2024. It is now read-only.

Correct replicator states #486

Merged
merged 1 commit into from
Nov 24, 2020
Merged

Conversation

ricellis
Copy link
Member

Checklist

  • Tick to sign-off your agreement to the Developer Certificate of Origin (DCO) 1.1
  • Added tests for code changes or test/build only changes
  • Updated the change log file (CHANGES.md) or test/build only changes
  • Completed the PR template below:

Description

Correct the list of valid replicator states

Fixes #464

Approach

  • Add the failed state to follow_replication since this is another condition under which it should exit in CouchDB 2.1+.

Schema & API Changes

follow_replication exits for the error state even though that is a retryable state in CouchDB 2.1+ systems, it was existing behaviour for Couch < 2.1. Using the error state as an exit condition is retained so the code continues to operate in the same way as it has since launch when interacting with CouchDB >=2.1 based servers.

Behaviour change for the failed state which should have ended follow_replication but didn't, this is a fix.

Security and Privacy

  • "No change"

Testing

The replicator tests were missing some other states introduced in CouchDB 2.1 scheduler.

  • Modified existing tests because they did not have the complete list of replicator states for CouchDB 2.1+ and intermittently failed as a result.

Monitoring and Logging

  • "No change"

Add the `failed` state to `follow_replication`.
The replicator tests were missing some other states introduced in CouchDB 2.1 scheduler.
@ricellis ricellis self-assigned this Nov 20, 2020
@ricellis ricellis added this to the 2.next milestone Nov 20, 2020
@mojito317 mojito317 self-requested a review November 24, 2020 09:27
@ricellis ricellis merged commit f7d0cb0 into master Nov 24, 2020
@ricellis ricellis deleted the 464-replication-follow-failure branch November 24, 2020 13:09
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Intermittent follow_replication test failure
3 participants