Linting(and a fix) #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
realtyem
force-pushed
the
psycopg-linting
branch
from
7b8b5a8 to
e199ea9
Compare
…lated classes LoggingTransaction shouldn't care that this is a specifically psycopg function as for now it only deals with queries made of strings
The alternative I want to explore here is based on executemany or execute, however it is much more invasive than originally planned for.
…) for the moment See comment in commit. This will need bigger surgery
Not completely convinced, but mypy is ok with it
realtyem
force-pushed
the
psycopg-linting
branch
from
d3ee088 to
d6b307c
Compare
…d psycopg2, fixup Typing through all versions of same This has no change of behavior, but did help expose the next commit
…EATABLE_READ. This is why
clokep
reviewed
Oct 23, 2024
| @@ -71,6 +71,7 @@ | |||
| PsycopgEngine, | |||
| Sqlite3Engine, | |||
| ) | |||
| from synapse.storage.engines._base import IsolationLevel | |||
There was a problem hiding this comment.
Are all the isolation level changes somewhat unrelated to this (it just happens to work on current develop because it is an int, where this branch it is not necessarily?)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bunch of stuff, check individual commits for longer messages(sometimes)
Except for the SQLBaseStoreTestCase conditions, the rest should be straight linting fixes