-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rework credential on file with cardholder/spitballing #83
base: cof-c
Are you sure you want to change the base?
Conversation
|
||
Subsequent authorizations are made by using | ||
`credential_on_file[previous]=<ID>`, where `<ID>` is the `id` of the previous | ||
transaction in the series. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've documented it as the ("full") reference, like /authorizations/:id
, and I have a reason for that. (Hint: "abstract transaction".) 🙂
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
At least I think we need to be a bit more precise than "the previous transaction". Is it the authorization or the capture for the transaction? Also, in my opinion we should mention an age limit, e.g. 13 months.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ct-clearhaus abstract transaction as in?
I agree that we need to be more precise. But we should also be terse.
I'll see what I can do.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But I guess previous
depends on how we accept continued transactions in our API.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"Abstract transaction": https://github.com/clearhaus/issues-pci/issues/1071#issuecomment-517264132
The subsection is in the "Examples" section, so I think we should really try to keep it short and "just an example" rather than a full-ish detailed description. The details should go to the reference section IMO. Perhaps we should completely avoid mentioning UCOF and CIT-only COF in the Examples section and just have a recurring example? |
source/index.html.md
Outdated
@@ -340,6 +340,23 @@ Example response (snippet): | |||
|
|||
## Credential on file | |||
|
|||
This indicates that the cardholders payment information is being stored by the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
*cardholder's
source/index.html.md
Outdated
required.) | ||
|
||
To store and use these stored payment credentials, the transactions that stores | ||
the card must be marked with `credential_on_file[type]=cardholder`. All |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
that stores the credentials
source/index.html.md
Outdated
To store payment credentials and use these stored payment credentials, | ||
`credential_on_file[]` must be used. All transactions in such a series are | ||
cardholder-initiated. | ||
### Subsequent Credential on file |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
*credential
source/index.html.md
Outdated
### Subsequent Credential on file | ||
|
||
First in series transactions can also be made using the `applepay` and | ||
`mobilepayonline` payment methods; however, subsequent merchant-initiated |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
methods, however
source/index.html.md
Outdated
First in series transactions can also be made using the `applepay` and | ||
`mobilepayonline` payment methods; however, subsequent merchant-initiated | ||
transactions must be made using the `card` payment method using the card | ||
details of the initial recurring authorization. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps refer to it as "the first in series authorization" as that term is used in the beginning of the paragraph?
|
||
Subsequent authorizations are made by using | ||
`credential_on_file[previous]=<ID>`, where `<ID>` is the `id` of the previous | ||
transaction in the series. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
At least I think we need to be a bit more precise than "the previous transaction". Is it the authorization or the capture for the transaction? Also, in my opinion we should mention an age limit, e.g. 13 months.
No description provided.