Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework credential on file with cardholder/spitballing #83

Draft
wants to merge 2 commits into
base: cof-c
Choose a base branch
from

Conversation

kse-clearhaus
Copy link
Contributor

No description provided.

@kse-clearhaus kse-clearhaus requested a review from a team August 15, 2019 07:27

Subsequent authorizations are made by using
`credential_on_file[previous]=<ID>`, where `<ID>` is the `id` of the previous
transaction in the series.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've documented it as the ("full") reference, like /authorizations/:id, and I have a reason for that. (Hint: "abstract transaction".) 🙂

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At least I think we need to be a bit more precise than "the previous transaction". Is it the authorization or the capture for the transaction? Also, in my opinion we should mention an age limit, e.g. 13 months.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ct-clearhaus abstract transaction as in?

I agree that we need to be more precise. But we should also be terse.
I'll see what I can do.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But I guess previous depends on how we accept continued transactions in our API.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ct-clearhaus
Copy link
Member

The subsection is in the "Examples" section, so I think we should really try to keep it short and "just an example" rather than a full-ish detailed description. The details should go to the reference section IMO.

Perhaps we should completely avoid mentioning UCOF and CIT-only COF in the Examples section and just have a recurring example?

@@ -340,6 +340,23 @@ Example response (snippet):

## Credential on file

This indicates that the cardholders payment information is being stored by the
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

*cardholder's

required.)

To store and use these stored payment credentials, the transactions that stores
the card must be marked with `credential_on_file[type]=cardholder`. All
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that stores the credentials

To store payment credentials and use these stored payment credentials,
`credential_on_file[]` must be used. All transactions in such a series are
cardholder-initiated.
### Subsequent Credential on file
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

*credential

### Subsequent Credential on file

First in series transactions can also be made using the `applepay` and
`mobilepayonline` payment methods; however, subsequent merchant-initiated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

methods, however

First in series transactions can also be made using the `applepay` and
`mobilepayonline` payment methods; however, subsequent merchant-initiated
transactions must be made using the `card` payment method using the card
details of the initial recurring authorization.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps refer to it as "the first in series authorization" as that term is used in the beginning of the paragraph?


Subsequent authorizations are made by using
`credential_on_file[previous]=<ID>`, where `<ID>` is the `id` of the previous
transaction in the series.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At least I think we need to be a bit more precise than "the previous transaction". Is it the authorization or the capture for the transaction? Also, in my opinion we should mention an age limit, e.g. 13 months.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants