Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Visa Direct - Purpose of payment #188

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from
Draft

Conversation

Lassejoe
Copy link
Contributor

@Lassejoe Lassejoe commented Mar 18, 2024

As a part of: https://github.com/clearhaus/issues-project-management/issues/264

Visa requires Purpose of payment on both AFT and OCT for cross-border transactions.

Based on Visas Purpose of Payment - Standardized Codes List I can only see 6 character codes in the list.

Copy link
Contributor

@cbobach cbobach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we need to highlight that these are only Visa specific fields, know that you specify the naming of the document.

I'm not sure which parts/information we normally put in the Partner Guideline and which we add here, but think information in the line of these is not something we have added to the api-docs previously 🤷

@Lassejoe Lassejoe requested a review from a team March 19, 2024 07:16
{{% description_term %}}purpose_of_payment {{% regex %}}[A-Z]{6}{{% /regex %}}{{% /description_term %}}
{{% description_details %}} The fields code shall reflect the nature and purpose of the transaction.
Valid codes are list in Visas Purpose of Payment - Standardized Codes List.
{{% regex_optional %}} Required for Visa cross-border transactions destined for Argentina, Bangladesh, Chile, Columbia, Egypt, India and Mexico. {{% /regex_optional %}}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
{{% regex_optional %}} Required for Visa cross-border transactions destined for Argentina, Bangladesh, Chile, Columbia, Egypt, India and Mexico. {{% /regex_optional %}}
{{% regex_optional %}}Required for Visa cross-border transactions destined for some specific countries; otherwise optional. See the partner guideline for details.{{% /regex_optional %}}

Maybe? 😬

@@ -28,4 +28,10 @@ Example: "Doe Jane A." (last name, first name, optional middle initial).
{{% regex_optional %}}Required if the merchant account's Business Application Identifier (BAI) is Funds Disbursement (FD).{{% /regex_optional %}}
{{% /description_details %}}

{{% description_term %}}recipient[purpose_of_payment] {{% regex %}}[A-Z]{6}{{% /regex %}}{{% /description_term %}}
Copy link
Contributor

@mt-clearhaus mt-clearhaus Mar 19, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Purpose of Payment is not related to recipient data so it does not make sense to have it in the recipient dictionary.

AFAICT, we should the same as for credits, i.e. have it on the same level as e.g. text_on_statement. Because the Debits section currently only refers to the parameters for an authorization, we need to add a Parameters section to debits, stating that these parameters are in addition to the parameters supported for an authorization.

@@ -32,6 +32,12 @@ POST https://gateway.clearhaus.com/credits
{{% regex_optional %}}Optional{{% /regex_optional %}}
{{% /description_details %}}

{{% description_term %}}purpose_of_payment {{% regex %}}[A-Z]{6}{{% /regex %}}{{% /description_term %}}
{{% description_details %}} The fields code shall reflect the nature and purpose of the transaction.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
{{% description_details %}} The fields code shall reflect the nature and purpose of the transaction.
{{% description_details %}}The fields code shall reflect the nature and purpose of the transaction.

IMHO we should try to converge towards not having these purposeless spaces 🙂

@@ -32,6 +32,12 @@ POST https://gateway.clearhaus.com/credits
{{% regex_optional %}}Optional{{% /regex_optional %}}
{{% /description_details %}}

{{% description_term %}}purpose_of_payment {{% regex %}}[A-Z]{6}{{% /regex %}}{{% /description_term %}}
{{% description_details %}} The fields code shall reflect the nature and purpose of the transaction.
Valid codes are list in Visas Purpose of Payment - Standardized Codes List.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Valid codes are list in Visas Purpose of Payment - Standardized Codes List.
Valid codes are list in Visa's Purpose of Payment - Standardized Codes List.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants