Skip to content
This repository has been archived by the owner on Sep 23, 2024. It is now read-only.

Rename logger constant to LOGGER #152

Merged
merged 1 commit into from
May 22, 2018

Conversation

major
Copy link
Contributor

@major major commented May 21, 2018

Pylint's C0103 requires that constants are in uppercase.

This PR works towards #3.

Signed-off-by: Major Hayden [email protected]

Pylint's C0103 requires that constants are in uppercase.

Signed-off-by: Major Hayden <[email protected]>
@major major added the enhancement New feature or request label May 21, 2018
@major major self-assigned this May 21, 2018
@coveralls
Copy link

Pull Request Test Coverage Report for Build 480

  • 1 of 2 (50.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 46.658%

Changes Missing Coverage Covered Lines Changed/Added Lines %
skt/executable.py 1 2 50.0%
Totals Coverage Status
Change from base Build 463: 0.0%
Covered Lines: 684
Relevant Lines: 1466

💛 - Coveralls

Copy link
Contributor

@spbnick spbnick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Obviously good, but apparently needs a rebase :)

I have a feeling most of the PRs will...

@veruu
Copy link
Contributor

veruu commented May 22, 2018

@spbnick there is an "update branch" button, it creates a merge commit but you can then squash it when merging. Not sure how it works with multi-commit pulls but when there is a single one and no conflicts it's OK and avoids the constant rebase loop

@spbnick spbnick merged commit 83f5d50 into cki-project:master May 22, 2018
@major major deleted the rename-logger-constant branch May 22, 2018 14:00
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants