Skip to content
This repository has been archived by the owner on Sep 23, 2024. It is now read-only.

Fix pylint W1201: logging-not-lazy #149

Merged
merged 1 commit into from
May 22, 2018

Conversation

major
Copy link
Contributor

@major major commented May 21, 2018

This PR is working towards #3.

Signed-off-by: Major Hayden [email protected]

@major major added the enhancement New feature or request label May 21, 2018
@major major self-assigned this May 21, 2018
@coveralls
Copy link

coveralls commented May 21, 2018

Pull Request Test Coverage Report for Build 485

  • 0 of 4 (0.0%) changed or added relevant lines in 2 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage remained the same at 46.658%

Changes Missing Coverage Covered Lines Changed/Added Lines %
skt/init.py 0 2 0.0%
skt/runner.py 0 2 0.0%
Files with Coverage Reduction New Missed Lines %
skt/init.py 1 39.8%
Totals Coverage Status
Change from base Build 483: 0.0%
Covered Lines: 684
Relevant Lines: 1466

💛 - Coveralls

skt/__init__.py Outdated
logging.warning(
"Bisected, bad commit: %s",
binfo
)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we not expand the lines this way if it's not needed? When the lines are this short, it doesn't help readability :/

skt/runner.py Outdated
"%s: %s",
jobid,
recipe.attrib.get("system")
)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here, it doesn't look like it's needed to fit the line.

@major major force-pushed the pylint-w1201-lazy-logging branch from ebe8039 to 1df028a Compare May 22, 2018 12:05
@major
Copy link
Contributor Author

major commented May 22, 2018

@veruu Just fixed that and rebased the patch.

@spbnick spbnick merged commit f077bf2 into cki-project:master May 22, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants