Skip to content
This repository has been archived by the owner on Sep 23, 2024. It is now read-only.

Remove unused variables #144

Merged
merged 1 commit into from
May 22, 2018
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions skt/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -200,7 +200,7 @@ def get_commit_date(self, ref=None):

logging.debug("git_commit_date: %s", args)
grs = subprocess.Popen(args, stdout=subprocess.PIPE)
(stdout, stderr) = grs.communicate()
(stdout, _) = grs.communicate()

return int(stdout.rstrip())

Expand Down Expand Up @@ -228,7 +228,7 @@ def get_commit(self, ref=None):

logging.debug("git_commit: %s", args)
grs = subprocess.Popen(args, stdout=subprocess.PIPE)
(stdout, stderr) = grs.communicate()
(stdout, _) = grs.communicate()

return stdout.rstrip()

Expand Down Expand Up @@ -278,7 +278,7 @@ def get_remote_url(self, remote):
"remote", "show", remote],
stdout=subprocess.PIPE,
stderr=subprocess.PIPE)
(stdout, stderr) = grs.communicate()
(stdout, _) = grs.communicate()
for line in stdout.split("\n"):
m = re.match('Fetch URL: (.*)', line)
if m:
Expand Down Expand Up @@ -345,7 +345,7 @@ def merge_patchwork_patch(self, uri):
env=dict(os.environ, **{'LC_ALL': 'C'})
)

(stdout, stderr) = gam.communicate(patch_content)
(stdout, _) = gam.communicate(patch_content)
retcode = gam.wait()

if retcode != 0:
Expand Down Expand Up @@ -389,7 +389,7 @@ def bisect_start(self, good):
"--git-dir", self.gdir,
"bisect", "start", "HEAD", good],
stdout=subprocess.PIPE)
(stdout, stderr) = gbs.communicate()
(stdout, _) = gbs.communicate()

for line in stdout.split("\n"):
m = re.match('^Bisecting: (.*)$', line)
Expand All @@ -416,7 +416,7 @@ def bisect_iter(self, bad):
"--git-dir", self.gdir,
"bisect", status],
stdout=subprocess.PIPE)
(stdout, stderr) = gbs.communicate()
(stdout, _) = gbs.communicate()

for line in stdout.split("\n"):
m = re.match('^Bisecting: (.*)$', line)
Expand Down Expand Up @@ -497,7 +497,7 @@ def getrelease(self):

args = self.defmakeargs + ["kernelrelease"]
mk = subprocess.Popen(args, stdout=subprocess.PIPE)
(stdout, stderr) = mk.communicate()
(stdout, _) = mk.communicate()
for line in stdout.split("\n"):
m = re.match(r'^\d+\.\d+\.\d+.*$', line)
if m:
Expand Down
2 changes: 1 addition & 1 deletion skt/executable.py
Original file line number Diff line number Diff line change
Expand Up @@ -149,7 +149,7 @@ def cmd_merge(cfg):
for mb in cfg.get('merge_ref'):
save_state(cfg, {'mergerepo_%02d' % idx: mb[0],
'mergehead_%02d' % idx: bhead})
(retcode, head) = ktree.merge_git_ref(*mb)
(retcode, _) = ktree.merge_git_ref(*mb)

utypes.append("[git]")
idx += 1
Expand Down
2 changes: 1 addition & 1 deletion skt/reporter.py
Original file line number Diff line number Diff line change
Expand Up @@ -385,7 +385,7 @@ def getjobresults(self):
if recipe == "result":
continue

(res, system, clogurl, slshwurl, llshwurl) = rdata
(res, system, clogurl, slshwurl, _) = rdata

clog = consolelog(self.cfg.get("krelease"), clogurl)
if not clog.data and res != 'Pass':
Expand Down
8 changes: 4 additions & 4 deletions skt/runner.py
Original file line number Diff line number Diff line change
Expand Up @@ -113,7 +113,7 @@ def getresultstree(self, jobid, logs=False):
args.append(jobid)

bkr = subprocess.Popen(args, stdout=subprocess.PIPE)
(stdout, stderr) = bkr.communicate()
(stdout, _) = bkr.communicate()
return etree.fromstring(stdout)

def dumpjunitresults(self, jobid, junit):
Expand All @@ -130,7 +130,7 @@ def dumpjunitresults(self, jobid, junit):
fname = "%s/%s.xml" % (junit, jobid.replace(":", "_").lower())
with open(fname, 'w') as fp:
bkr = subprocess.Popen(args, stdout=fp)
(stdout, stderr) = bkr.communicate()
bkr.communicate()

def getconsolelog(self, jobid=None):
"""
Expand Down Expand Up @@ -253,7 +253,7 @@ def getresults(self, jobid=None):
tfailures = 0

if jobid is not None:
(ret, result) = self.jobresult(jobid)
(ret, _) = self.jobresult(jobid)

if jobid is None or ret != 0:
for (recipe, data) in self.failures.iteritems():
Expand Down Expand Up @@ -414,7 +414,7 @@ def jobsubmit(self, xml):
bkr = subprocess.Popen(args, stdin=subprocess.PIPE,
stdout=subprocess.PIPE)

(stdout, stderr) = bkr.communicate(xml)
(stdout, _) = bkr.communicate(xml)

for line in stdout.split("\n"):
m = re.match(r"^Submitted: \['([^']+)'\]$", line)
Expand Down