Skip to content
This repository has been archived by the owner on Sep 23, 2024. It is now read-only.

Commit

Permalink
Rename kbuilder to KernelBuilder
Browse files Browse the repository at this point in the history
The name `kbuilder` violates class naming requirements set by pylint.

Signed-off-by: Major Hayden <[email protected]>
  • Loading branch information
major authored and spbnick committed May 22, 2018
1 parent 83f5d50 commit 89a7d9c
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 4 deletions.
2 changes: 1 addition & 1 deletion skt/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -436,7 +436,7 @@ def bisect_iter(self, bad):
return (ret, binfo)


class kbuilder(object):
class KernelBuilder(object):
def __init__(self, path, basecfg, cfgtype=None, makeopts=None,
enable_debuginfo=False):
self.path = path
Expand Down
2 changes: 1 addition & 1 deletion skt/executable.py
Original file line number Diff line number Diff line change
Expand Up @@ -200,7 +200,7 @@ def cmd_build(cfg):
tstamp = datetime.datetime.strftime(datetime.datetime.now(),
"%Y%m%d%H%M%S")

builder = skt.kbuilder(
builder = skt.KernelBuilder(
cfg.get('workdir'),
cfg.get('baseconfig'),
cfg.get('cfgtype'),
Expand Down
4 changes: 2 additions & 2 deletions tests/test_init.py
Original file line number Diff line number Diff line change
Expand Up @@ -67,11 +67,11 @@ def test_multipart_encoded_subject(self):

class KBuilderTest(unittest.TestCase):
# (Too many instance attributes) pylint: disable=R0902
"""Test cases for skt.kbuilder class"""
"""Test cases for skt.KernelBuilder class"""
def setUp(self):
self.tmpdir = tempfile.mkdtemp()
self.tmpconfig = tempfile.NamedTemporaryFile()
self.kbuilder = skt.kbuilder(self.tmpdir, self.tmpconfig.name)
self.kbuilder = skt.KernelBuilder(self.tmpdir, self.tmpconfig.name)
self.m_popen = Mock()
self.m_popen.returncode = 0
self.ctx_popen = mock.patch('subprocess.Popen',
Expand Down

0 comments on commit 89a7d9c

Please sign in to comment.