fix runaway workflowId parameter

cisco-open · Jan 26, 2024 · dbf5651 · dbf5651
1 parent e8830b9
commit dbf5651
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 5 deletions.
diff --git a/src/test/StatedWorkflow.test.js b/src/test/StatedWorkflow.test.js
@@ -496,6 +496,9 @@ test("recover incomplete workflow - should rerun all steps", async () => {
     tp.options = {'keepLogs': true}
     await tp.initialize();
     const {step0, step1, step2} = tp.output;
+    while(tp.output.step2.log['1697402819332-9q6gg'] === undefined || tp.output.step2.log['1697402819332-9q6gg'].end === undefined){
+        await new Promise(resolve => setTimeout(resolve, 50)); // Poll every 50ms
+    }
     expect(step0.log['1697402819332-9q6gg'].end).exists;
     expect(step1.log['1697402819332-9q6gg'].start).exists;
     expect(step1.log['1697402819332-9q6gg'].end).exists;
@@ -555,14 +558,15 @@ test("recover incomplete workflow - step 1 is incomplete - should rerun steps 1
     // keep steps execution logs for debugging
     tp.options = {'keepLogs': true}
     await tp.initialize();
-    console.log(tp.output);
     const {step0, step1, step2} = tp.output;
-    expect(step0.log['1697402819332-9q6gg'].end).toBeDefined();
-    expect(step1.log['1697402819332-9q6gg'].start).toBeDefined();
-    expect(step1.log['1697402819332-9q6gg'].end).toBeDefined();
     while(tp.output.step2.log['1697402819332-9q6gg'] === undefined || tp.output.step2.log['1697402819332-9q6gg'].end === undefined){
         await new Promise(resolve => setTimeout(resolve, 50)); // Poll every 50ms
     }
+
+    expect(step0.log['1697402819332-9q6gg'].end).toBeDefined();
+    expect(step1.log['1697402819332-9q6gg'].start).toBeDefined();
+    expect(step1.log['1697402819332-9q6gg'].end).toBeDefined();
+
     expect(step2.log['1697402819332-9q6gg'].start).toBeDefined();
     expect(step2.log['1697402819332-9q6gg'].end).toBeDefined();
     expect(step2.log['1697402819332-9q6gg'].end.out).toMatchObject({

diff --git a/src/workflow/Step.js b/src/workflow/Step.js
@@ -91,7 +91,7 @@ export default class Step {
                 if (retryCount !== undefined) {
                     await this.tp.setData(jsonPtr + "/retryCount", ++retryCount);
                 }
-                let out = await fn.apply(this, [args]);
+                let out = await fn.apply(this, [args, {workflowInvocation}]);
                 const end = {
                     timestamp: new Date().getTime(),
                     out