Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Render captions to m.file, m.image, m.video, and m.audio #2059

Merged
merged 11 commits into from
Jan 6, 2025

Conversation

nexy7574
Copy link
Contributor

@nexy7574 nexy7574 commented Nov 17, 2024

Description

This PR will introduce rendering file captions.
These were introduced in spec v1.10, and have recently seen wide adoption amongst Element and other clients. It is time that cinny had this too.

Sending captions is out of scope for this PR and will be introduced later.

Fixes partially #1646

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

Copy link

github-actions bot commented Nov 17, 2024

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

@nexy7574
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

ajbura added a commit to cinnyapp/cla that referenced this pull request Nov 17, 2024
Copy link

github-actions bot commented Nov 17, 2024

Preview: https://2059--pr-cinny.netlify.app
⚠️ Exercise caution. Use test accounts. ⚠️

@nexy7574 nexy7574 changed the title Add captions to m.image Add captions to m.file, m.image, m.video, and m.audio Nov 18, 2024
src/app/components/RenderMessageContent.tsx Outdated Show resolved Hide resolved
src/app/components/RenderMessageContent.tsx Outdated Show resolved Hide resolved
src/app/features/room/RoomInput.tsx Outdated Show resolved Hide resolved
src/app/features/room/RoomInput.tsx Outdated Show resolved Hide resolved
src/app/features/room/RoomInput.tsx Outdated Show resolved Hide resolved
@nexy7574 nexy7574 requested a review from ajbura December 16, 2024 14:58
Copy link
Member

@ajbura ajbura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the changes!

src/app/components/RenderMessageContent.tsx Outdated Show resolved Hide resolved
@kfiven kfiven changed the title Add captions to m.file, m.image, m.video, and m.audio Render captions to m.file, m.image, m.video, and m.audio Jan 6, 2025
@kfiven kfiven merged commit 02437a6 into cinnyapp:dev Jan 6, 2025
2 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jan 6, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants