Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix ol listing #14

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Bugfix ol listing #14

wants to merge 1 commit into from

Conversation

gkermer
Copy link

@gkermer gkermer commented Sep 16, 2019

No description provided.

@chriskonnertz chriskonnertz self-requested a review September 19, 2019 09:54
@chriskonnertz chriskonnertz self-assigned this Sep 19, 2019
@chriskonnertz
Copy link
Owner

Hello,

thank you for creating this pull request! 👍
So did ol-Lists not work at all before? Or what is the issue that your change fixes here?

@gkermer
Copy link
Author

gkermer commented Dec 5, 2019

Hello,

Thank you for your reply.

Yes, it parses
[list=1][*]text 1[*]text 2[*]text 3[/list]
to
<ol></li><li>text 1</li><li>text 2</li><li>text 3</li></ol>

As you see, there is a </li> on the start.

By the way, you should create a test for [list=1].

Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants