-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
run nightly nightly #765
run nightly nightly #765
Conversation
right now there is a lot of CI spam from coverage reports on packages we don't care about, I think this is a vestigial organ left over from when CI was on travis, I don't believe this env variable gets set on github actions like it did on travis
…ee environment.yml for work around
…ff.toolkit.topology import Molecule/g'
Co-authored-by: Jaime Rodríguez-Guerra <[email protected]>
…ing things as failed
fix syntax error with yml
@jaimergp Not exactly what is wrong with the syntax in the new Nightly.yml file, but my idea was to move the nightly testing as part of a cron job and not test PRs against nightly. This should make a github issue when nightly fails, which should help keep those issues visible. |
What if instead of having different workflows we use conditionals based on |
Co-authored-by: Jaime Rodríguez-Guerra <[email protected]>
That could work and cuts down on the duplication. At one point I split the checks into a new workflow so they wouldn't block auto merging or make it look like our build was failing when it wasn't, but I think marking the checks as not required should fix that, I'll give it a try. |
Co-authored-by: Jaime Rodríguez-Guerra <[email protected]>
Part of what I'm trying to do is not have our build badge be red, but I think I've fixed that by chancing which checks are required |
Going to work on making nightly work |
Instead of including checks against nightly openmm builds on ever PR, we will run checks every night and if they fail make an issue on github
This PR will be smaller when PR #760 and PR #763 get merged in.