Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update and rename Grad Student.YAML to Full Name with Spaces.yaml #3

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

egoldber
Copy link
Contributor

updated file to be correct yaml format, changed strings to lists, added funding, birthday

updated file to be correct yaml format, changed strings to lists, added funding, birthday
@egoldber egoldber requested a review from jchodera April 13, 2022 18:54
Copy link
Member

@jchodera jchodera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you revise this?

Make sure to read more about valid YAML syntax here: https://yaml.org/

Please use the YAML syntax checker to make sure this example is valid YAML.

birthday: MM.DD
position: (Job Title) (Graduate Student) (Postoctoral Research Scholar/Fellow)
affiliations: >
Weill Cornell Physiology, Biophysics, and Systems Biology PhD Program
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we make this a list instead of text? So:

affiliations:
  - Weill Cornell Biochemistry and Structural Biology PhD Program
  - Tri-Institutional PhD Program in Computational Biology and Medicine
  - Tri-Institutional PhD Program in Chemical Biology
  - Louis V. Gerstner, Jr. Graduate School of Biomedical Sciences
  - Berlin Institute of Health (BIH) Einstein Foundation - Stiftung Charité Group
  - Joint Mentorship with Name (URL to lab)

Louis V. Gerstner, Jr. Graduate School of Biomedical Sciences
Berlin Institute of Health (BIH) Einstein Foundation - Stiftung Charité Group
Joint Mentorship with Name (URL to lab)
fellowships: >
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here: This should be a list.
Maybe it should be awards?

We can use comments to explain how folks should fill this in:

# List all awards and fellowships here
awards:
  - Ig Nobel Prize in Economics
  - Lithuanian Horticultural Society Outstanding Mentorship Award
  - NSF GRFP Graduate Fellowship
  - American Philatelic Society Poster Prize

email: @choderalab.org
telephone:
twitter: handle (NO@)
linkedin: URL
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make it clear that these fields can be commented out if you don't have one of them:

# Comment out these fields if they don't apply to you
linkedin: # URL

status: current
start-date: YYYY.MM.DD
end-date: YYYY.MM.DD
email: @choderalab.org
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(Any awards you have won) (i.e. MolSSI Investment Fellowship)
funding: >
(list of funding sources)
status: current
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This syntax is invalid, and the date format needs to be easily parseable in Python.

How about

# Key dates. Comment out dates that don't apply to you.
dates:
  start: YYYY-MM-DD
  ace: YYYY-MM-DD
  committee-meetings:
    - YYYY-MM-DD
    - YYYY-MM-DD
  end: YYYY-MM-CC

end-date: YYYY.MM.DD
email: @choderalab.org
telephone:
twitter: handle (NO@)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

# twitter handle (if applicable); do not include '@'
twitter: jchodera

CV: (URL to PDF)
project(s): >
name
associations: >
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs to be a list, like

# Keywords association with various subgroups
associations:
  - perses
  - espaloma
  - pymbar
  - openmmtools
  - yank
  - rocsalt

Is it meant to be github repositories they're associated with? If so, maybe contributions: would be better.

ORCID:
google-scholar: URL
CV: (URL to PDF)
project(s): >
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think project(s): is invalid.
Let's do

projects:
  - espaloma
  - perses
  - ml-potential

Somewhere else, we'd need to capture a list of projects with the same keywords.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alternatively, we can solicit text descriptions of the projects, which is the more useful thing to do right now!

# Brief descriptions of each project you are involved in (to appear on webpage)
projects:
- End-to-end differentiable fitting of molecular mechanics force fields
- Alchemical free energy calculations that can learn
- Machine learning for drug discovery
- Large-scale molecular dynamics simulations of transmembrane proteins

folding@home
yank
rocsalt
interests: >
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interests should also be a list of text/keywords:

interests:
  - machine learning
  - free energy calculations
  - blind predictive modeling challenges
  - automation
  - Folding@home
  - cats

Copy link
Contributor Author

@egoldber egoldber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Responded to comments from JDC and fixed .yaml file based off of suggestions

Copy link
Contributor Author

@egoldber egoldber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jchodera attempt number 2!?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants