Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(maint) Rename Pester Tests Directory #3345

Merged
merged 2 commits into from
Dec 8, 2023
Merged

Conversation

corbob
Copy link
Member

@corbob corbob commented Oct 16, 2023

Description Of Changes

Rename the Pester tests directory to bring it in line with the Pester tests directory used in other products.

Motivation and Context

The Test Kitchen environment has been updated to pull in tests from all of the product repositories. In order to accomplish this without the need for a script for each repository, they are all using the pattern of putting the pester tests under tests/pester-tests.

Testing

See the Test Kitchen PR: https://gitlab.com/chocolatey/build-automation/chocolatey-test-kitchen/-/merge_requests/177

Operating Systems Testing

Windows 10 and macOS hosts for Test Kitchen.

Ran the Vagrant testing environment - 127 test failures including 5 test container failures. This is the same number of failures as running it on the develop branch.

Change Types Made

  • Bug fix (non-breaking change).
  • Feature / Enhancement (non-breaking change).
  • Breaking change (fix or feature that could cause existing functionality to change).
  • Documentation changes.
  • PowerShell code changes.

Change Checklist

  • Requires a change to the documentation.
  • Documentation has been updated.
  • Tests to cover my changes, have been added.
  • All new and existing tests passed?
  • PowerShell code changes: PowerShell v2 compatibility checked?

Related Issue

ENGTASKS-2992

@corbob corbob self-assigned this Oct 16, 2023
This commit renames the Pester tests directory from chocolatey-tests to
pester-tests. This allows our script to pull consistently from all of our
repositories without worrying about which repository it's coming from.
@corbob corbob changed the title rename tests directory (maint) Rename Pester Tests Directory Oct 25, 2023
Update invoke script for new Pester tests location.
@corbob corbob marked this pull request as ready for review October 25, 2023 21:02
Copy link
Member

@gep13 gep13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@gep13 gep13 merged commit ff37b55 into chocolatey:develop Dec 8, 2023
4 checks passed
@gep13
Copy link
Member

gep13 commented Dec 8, 2023

@corbob thanks for getting this updated!

@corbob corbob deleted the move-tests branch December 8, 2023 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants