(#3342) Separate TeamCity Builds: Unit test, Scheduled integration test, QA #3343
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Windos
force-pushed
the
GH-3342/separate-teamcity-builds
branch
from
7435faf to
324fdae
Compare
|
@gep13 - the GitHub Action for this PR is failing on the PSScriptAnalyzer step. I've set running this to |
Windos
force-pushed
the
GH-3342/separate-teamcity-builds
branch
2 times, most recently
from
9f9d9b5 to
aa3ae48
Compare
The default shell on Windows runners is pwsh, but running the PSSA task under pwsh was resulting in an error running `Install-Module`. This error is not exhibited when running under Windows Powershell.
Windos
force-pushed
the
GH-3342/separate-teamcity-builds
branch
from
a1b0cca to
a0e5728
Compare
|
@gep13 - I've cleaned up my commits on the PR and it's ready for review now. With Chocolatey.Cake.Recipe 0.26.3 everything is now working on TeamCity and with a slight workflow tweak to change the PowerShell shell, the GitHub Action is working too. |
|
@Windos thank you for pulling all this together! Looking forward to seeing this in action! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description Of Changes
This PR splits the current general TeamCity build which runs unit tests on a version control trigger and unit + integration tests on a schedule into two separate builds:
ID: ChocolateyID: ChocolateySchdIt also introduces an additional build specifically for running Code Analysis and Dependency Checking:
ID: ChocolateyQANote: Please advise if these names are appropriate, and recommend alternatives as needed.
Motivation and Context
This change enables TeamCity to accurately track how long each build configuration should take to run and how many tests each should run.
Testing
This has been tested on a non-Production TeamCity instance, the KTS file imported successfully and the three builds ran as expected.
Operating Systems Testing
N/A
Change Types Made
N/A? Build change
Change Checklist
Related Issue
Fixes #3342