Fixes bash issue with parsing with multiple VPC CIDR blocks #121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an issue introduced in #116 where configurations with multiple VPC CIDR blocks attached to a VPC would result in only one range being added to the NAT table. Connections from clients in the additional VPCs would not be NAT'd.
This is due to a difference in
readbehavior with regard to newlines. AL2 was using bash ~4.3 r46, while AL2023 uses 5.2. Many changes toIFSandreadwere made in between releases, and one of those changed the behavior such that the list was not being parsed correctly.This PR updates the parsing to use
readarraywhich does work with the list of CIDR ranges returned from the metadata endpoint. Also updates the test to include a secondary CIDR range on the VPC.