-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add(crit): other os support #197
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #197 +/- ##
==========================================
+ Coverage 48.83% 49.80% +0.97%
==========================================
Files 21 21
Lines 2353 2307 -46
==========================================
Hits 1149 1149
+ Misses 1065 1019 -46
Partials 139 139 ☔ View full report in Codecov by Sentry. |
Thanks. Can you add a CI run on a non Linux platform. To ensure we do not break non Linux support in the future. |
I have added tests for macOS. However, since I only have access to a Mac, I was unable to create tests for the Windows environment. Additionally, I haven't written many tests before, so I'm not sure if I did them correctly. Could you please review the changes? Thank you. |
@rst0git @snprajwal The failures using the criu master branch is probably related to outdated image protobuf definitions. Can anyone of you update the definitions in this repository to the latest version from CRIU upstream. |
@cg10036 could you please rebase your changes on top of the master branch? Also, it would be great if you could squash the commits down into a single logical commit :) we tend to avoid fixup commits in general, since they pollute the commit history of the project. |
Signed-off-by: cg10036 <[email protected]>
I've rebased and squashed the commits as requested. Let me know if you need anything else! |
Signed-off-by: cg10036 <[email protected]>
@rst0git @snprajwal Looks ready to me. Anything from your side? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@cg10036 Thank you for working on this!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
9996dd5
into
checkpoint-restore:master
When using CRIT on macOS, the following errors occur:
I believe that CRIT can be sufficiently supported even on non-Linux platforms. Therefore, I have added the necessary support.