-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ListFolders() #48
Closed
Closed
ListFolders() #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Interface methods
alice-sawatzky
force-pushed
the
list-dirs
branch
from
August 10, 2020 16:44
c64ceb7
to
fa2e1ce
Compare
alice-sawatzky
force-pushed
the
list-dirs
branch
from
August 10, 2020 17:14
b4cd8e5
to
7b4c471
Compare
alice-sawatzky
force-pushed
the
list-dirs
branch
from
August 10, 2020 17:16
7b4c471
to
05c5c52
Compare
won't work until we add ListFolders to the Backend interface
This reverts commit fe3b508.
alice-sawatzky
force-pushed
the
list-dirs
branch
from
August 10, 2020 20:05
097d9d4
to
47d560b
Compare
4 tasks
@alice-sawatzky - had some issues here updating branch names. Can you please re-open against |
done, recreated at #56 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
ListFolders()
function to all storage modules. Refactor modules to use an iterator to reduce redundant code between ListObjects() and ListFolders().The goal is to support a chartmuseum endpoint described in helm/chartmuseum#360.
This is my first contribution to a Go project so feedback and patience is appreciated!
Progress:
And once those are done: