Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ListFolders() #48

Closed
wants to merge 29 commits into from
Closed

Conversation

alice-sawatzky
Copy link

@alice-sawatzky alice-sawatzky commented Aug 10, 2020

Add ListFolders() function to all storage modules. Refactor modules to use an iterator to reduce redundant code between ListObjects() and ListFolders().

The goal is to support a chartmuseum endpoint described in helm/chartmuseum#360.

This is my first contribution to a Go project so feedback and patience is appreciated!

Progress:

  • alibaba
  • amazon
  • baidu
  • etcd
  • google
  • local
  • microsoft
  • netease
  • openstack
  • oracle
  • tencent

And once those are done:

  • update Backend interface
  • beef up tests a bit

@alice-sawatzky alice-sawatzky marked this pull request as draft August 10, 2020 16:52
@alice-sawatzky alice-sawatzky marked this pull request as ready for review August 10, 2020 21:52
@alice-sawatzky alice-sawatzky changed the title [WIP] ListFolders() ListFolders() Aug 10, 2020
@jdolitsky jdolitsky added this to the v0.11.0 milestone Nov 12, 2020
@jdolitsky jdolitsky closed this Nov 12, 2020
@jdolitsky jdolitsky deleted the branch chartmuseum:master November 12, 2020 04:24
@jdolitsky
Copy link
Collaborator

@alice-sawatzky - had some issues here updating branch names. Can you please re-open against main ?

@alice-sawatzky
Copy link
Author

alice-sawatzky commented Nov 18, 2020

done, recreated at #56

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants