-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add logo-use page linking to SMART guidelines #479
Conversation
<img width="60" src="/images/logo-square.png"> | ||
</center> | ||
|
||
The CDS Hooks logos are owned by The Children's Medical Center Corporation and may be used in accordance with guidelines and policy at [https://smarthealthit.org/cds-hooks-logo](https://smarthealthit.org/cds-hooks-logo). These guidelines describe how CDS Hooks logos can be used in connection with: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note that this is a 404 today; SMART will be adding content similar to https://smarthealthit.org/logo/ (but tailored for CDS Hooks, and without the need for a distinct "works with" logo.)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
Wouldn't it make more sense to wait until https://smarthealthit.org/cds-hooks-logo exists before merging? Why put a broken link on cds-hooks.org? Broken links simply degrade a visitor's trust in the site. Josh, do you have reason to believe that this link will function soon? |
We're working on getting content up, indeed. BCH counsel is drafting an updated, simplified set of guidelines. I think having the notice is strictly better than not -- but we can commit to getting a placeholder up to avoid a broken link ASAP, even before the guidelines are compete. |
Hey Josh, First - great work getting progress from BCH counsel! This is important stuff. I recommend three changes:
Apologies for the tardiness of this feedback. Isaac |
To be clear, I merged this after @brynrhodes's review yesterday. I'm happy to move the link to the bottom of the page, and to update the language to read "Boston Children's Hospital" per your suggestion (will do this in a follow-on PR). It's very helpful though to have this content in place as we get detailed guidance onto the smarthealthit.org site, so I hope it's okay that we have a pointer to content-in-progress. (To be fair, the terms are always in-progress in the sense that they can be changed, so I don't see this as a huge limitation, and in any case we should have more specifics shortly.) |
Updated #480 with your suggestions @isaacvetter |
Is https://smarthealthit.org/cds-hooks-logo/ complete?!?! |
I think so -- is there something surprising about it (given the double interrobang)?? |
This is a step toward resolving #475. The linked content at smarthealthit.org is not yet available, but is a work in progress. It would be good to incorporate this general guidance into the official docs, linking out to the more detailed guidelines.